Closed Bug 1254566 Opened 9 years ago Closed 9 years ago

Some setting row titles and sub-titles, when localized, do not fit on 3.5" devices

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios 3.0+ ---
fxios-v3.0 --- fixed
fxios-v4.0 --- fixed

People

(Reporter: st3fan, Assigned: sleroux)

References

Details

Attachments

(1 file, 1 obsolete file)

Github PR https://github.com/mozilla/firefox-ios/pull/1636
48 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review
Some setting row titles and sub-titles do not fit on 3.5" devices. See screenshots at: http://people.mozilla.org/~sarentz/fxios/screenshots/latest/de/screenshots.html
Summary: Some setting row titles and sub-titles do not fit on 3.5" devices → Some setting row titles and sub-titles, when localized, do not fit on 3.5" devices
Blocks: 1256395
Severity: normal → blocker
Assignee: nobody → sleroux
Attachment #8731248 - Flags: review?(sarentz)
Attachment #8731248 - Flags: review?(bnicholson)
Whiteboard: [needsuplift]
Comment on attachment 8731248 [details] [review] Github PR https://github.com/mozilla/firefox-ios/pull/1634 Worth testing on iPad since it can layout table cells differently. Everything else LGTM!
Attachment #8731248 - Flags: review?(bnicholson) → review+
Attachment #8731248 - Attachment is obsolete: true
Attachment #8731394 - Flags: review?(bnicholson) → review+
master 657b5b6a785b53ea2b9c4b48a2a7c01c6b441271
Status: NEW → RESOLVED
Closed: 9 years ago
status-fxios-v4.0: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 4.0
v3.x e878955]
status-fxios-v3.0: affected → fixed
Whiteboard: [needsuplift]
Don't know about TestFlight revisions but it doesn't look like it is working for sub-titles - https://people.mozilla.org/~sarentz/fxios/screenshots/latest/pl/pl/iPhone4s-50ClearPrivateData-10.png
Hey Stefan, The latest TF build (7) should have this patch. I don't think the screenshots have been updated yet since build 7 was made available on Saturday.
Then it doesn't work for sub-titles.
…but it seems to work in TF build (8) :)
Fixed in bug 1258643 probably.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: