1254574 - Create an Action for Open New Tab

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Emily Toop (:fluffyemily)]

Actions will be discrete bits of code that encompass a frequently performed action that can be called from anywhere in the code. It accepts as arguments everything it needs to perform its task. 

* Create an Action for New Tab
* Ensure New Tab Action can be called from Menu
* Call New Tab Action from everywhere we open a new tab in the app

Comment 1

[Emily Toop (:fluffyemily)]

Attachment: Pull request

First stab at Actions concept.

We have a MenuActions enum that enumerates the menu actions.
We have a MenuActionDelegate that handle menu actions

We have ActionHandlers that implement the Actionable protocol. We have an Action enum that enumerates the actions that can be handled by ActionHandlers. Each enum case requires all the things that the action needs in order to perform the action.

The MenuHandler takes the MenuAction and translates it into an Action, and then passes that action to the most appropriate ActionHandler to handle.

Here I have created a TabAction handler, listed all the tab actions and implemented those actions across the entire app, including from the appropriate menu items.

N.B. - The first two commits were my first thoughts on the matter, and then I changed my mind when I realised that it just wouldn't work.

Let this PR be a basis for discussion for the right way to handle Actions across the app.

Comment 2

[Stephan Leroux [:sleroux]]

Comment on attachment 8738594 [details] [review]
Pull request

Left some feedback on the PR!

Comment 3

[Emily Toop (:fluffyemily)]

Attachment: Pull request

Nothing fancy here, no major refactoring work - just getting the menu options working for Browser menu actions only (tab tray menu actions not available yet).

Also covers the following bugs:

https://bugzilla.mozilla.org/show_bug.cgi?id=1254575
https://bugzilla.mozilla.org/show_bug.cgi?id=1254586
https://bugzilla.mozilla.org/show_bug.cgi?id=1254587
https://bugzilla.mozilla.org/show_bug.cgi?id=1254577
https://bugzilla.mozilla.org/show_bug.cgi?id=1254576
https://bugzilla.mozilla.org/show_bug.cgi?id=1254599
https://bugzilla.mozilla.org/show_bug.cgi?id=1263178

Comment 4

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8739924 [details] [review]
Pull request

Comments in the PR (historical).