Add Menu button to browser toolbar

RESOLVED FIXED

Status

()

Firefox for iOS
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: fluffyemily, Assigned: fluffyemily)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

48 bytes, text/x-github-pull-request
jhugman
: review+
tecgirl
: ui-review+
sleroux
: feedback+
Details | Review | Splinter Review
48 bytes, text/x-github-pull-request
Details | Review | Splinter Review
(Assignee)

Description

2 years ago
We need to display the menu button on the browser toolbar. This will involve:

on iPhone portrait:

* make browser toolbar present on both browser and home panels
* remove bookmark icon from toolbar
* move share icon to bookmark position
* move refresh/stop loading icon to share position
* add menu icon at current refresh/stop loading position

on iPad portrait, iPad landscape & iPhone landscape:

* replace existing bookmark icon with menu icon
* ensure menu enabled even when top sites are displaying
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
Blocks: 1260124
No longer blocks: 1210109
(Assignee)

Comment 1

2 years ago
Created attachment 8735892 [details] [review]
Pull request
Attachment #8735892 - Flags: ui-review?(randersen)
Attachment #8735892 - Flags: review?(sleroux)
Attachment #8735892 - Flags: review?(jhugman)
Comment on attachment 8735892 [details] [review]
Pull request

LGTM! Left some chatter on the PR.
Attachment #8735892 - Flags: review?(sleroux) → review+
Comment on attachment 8735892 [details] [review]
Pull request

Sorry! Moving this to feedback+ instead of review+ to resolve the rotation popover issue I mentioned in the PR.
Attachment #8735892 - Flags: review?
Attachment #8735892 - Flags: review+
Attachment #8735892 - Flags: feedback+
Comment on attachment 8735892 [details] [review]
Pull request

Looking great to me.
Attachment #8735892 - Flags: review?(jhugman) → review+
Attachment #8735892 - Flags: ui-review?(randersen) → ui-review+
(Assignee)

Comment 5

2 years ago
Created attachment 8738464 [details] [review]
Pull Request

This is the merged pull request taken from original that got a tad screwed up with rebasing
(Assignee)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Attachment #8735892 - Flags: review?
You need to log in before you can comment on or make changes to this bug.