Closed Bug 1254657 Opened 5 years ago Closed 5 years ago

Fix issue with sending of Content:LoadURIResult

Categories

(Firefox :: Address Bar, defect)

42 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

RemoteWebProgress is currently sad because aMessage.json is null. Per discussion with mconley, we should treat the Content:LoadURIResult message specially and avoid the main switch statement for it, and just bail out quickly.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8728040 [details]
MozReview Request: Bug 1254657 - change how we send Content:LoadURIResult to avoid upsetting RemoteWebProgress.jsm, r?mconley

https://reviewboard.mozilla.org/r/38765/#review35421

LGTM - well spotted!

::: toolkit/modules/RemoteWebProgress.jsm:187
(Diff revision 1)
> +    if (aMessage.name == "Content:LoadURIResult") {

Maybe add a quick comment here saying that this is intentionally separated from the switch statement because it doesn't need to call any progress listeners, or something along those lines.
Attachment #8728040 - Flags: review?(mconley) → review+
https://hg.mozilla.org/mozilla-central/rev/75dbc6dae295
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.