Fix issue with sending of Content:LoadURIResult

RESOLVED FIXED in Firefox 48

Status

()

Firefox
Address Bar
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

42 Branch
Firefox 48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
RemoteWebProgress is currently sad because aMessage.json is null. Per discussion with mconley, we should treat the Content:LoadURIResult message specially and avoid the main switch statement for it, and just bail out quickly.
(Assignee)

Comment 1

2 years ago
Created attachment 8728040 [details]
MozReview Request: Bug 1254657 - change how we send Content:LoadURIResult to avoid upsetting RemoteWebProgress.jsm, r?mconley

Review commit: https://reviewboard.mozilla.org/r/38765/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38765/
Attachment #8728040 - Flags: review?(mconley)
(Assignee)

Updated

2 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8728040 [details]
MozReview Request: Bug 1254657 - change how we send Content:LoadURIResult to avoid upsetting RemoteWebProgress.jsm, r?mconley

https://reviewboard.mozilla.org/r/38765/#review35421

LGTM - well spotted!

::: toolkit/modules/RemoteWebProgress.jsm:187
(Diff revision 1)
> +    if (aMessage.name == "Content:LoadURIResult") {

Maybe add a quick comment here saying that this is intentionally separated from the switch statement because it doesn't need to call any progress listeners, or something along those lines.
Attachment #8728040 - Flags: review?(mconley) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/75dbc6dae295
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.