1254674 - Calling speak() on an empty utterance should not raise an error.

Status: NEW

(Core :: Web Speech, defect)

Description

[Eitan Isaacson [:eeejay]]

This seems to be an issue specifically on osx. I think that is not good. If anything, because of fingerprinting.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: MozReview Request: Bug 1254674 - Calling speak() on an empty utterance should not raise an error. r?eeejay

OSX's NSSpeechSynthesizer throws error when text is empty.  So we dispatch start and end event manually when text is empty.

Review commit: https://reviewboard.mozilla.org/r/43443/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43443/

Comment 2

[Eitan Isaacson [:eeejay]]

Comment on attachment 8736600 [details]
MozReview Request: Bug 1254674 - Calling speak() on an empty utterance should not raise an error. r?eeejay

https://reviewboard.mozilla.org/r/43443/#review40405

::: dom/media/webspeech/synth/cocoa/OSXSpeechSynthesizerService.mm:376
(Diff revision 1)
>  
> +  if (aText.IsEmpty()) {
> +    // NSSpeechSynthesizer throws error when text is empty.
> +    // If so, we dispatch start and end event instead of error
> +    aTask->DispatchStart();
> +    aTask->DispatchEnd(0, 0);

These methods are expected to be called asynchronously. Otherwise lockups and bad states happen. Here are some examples:
https://dxr.mozilla.org/mozilla-central/source/dom/media/webspeech/synth/speechd/SpeechDispatcherService.cpp#519

https://dxr.mozilla.org/mozilla-central/source/dom/media/webspeech/synth/test/nsFakeSynthServices.cpp#279

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.