Closed
Bug 1254726
Opened 9 years ago
Closed 9 years ago
Intermittent test_action-clear-snapshots_06.js | Test timed out
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: KWierso, Assigned: jdescottes)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
MozReview Request: Bug 1254726 - fix intermittent test_action-clear-snapshots_06 (osx10.6);r=fitzgen
58 bytes,
text/x-review-board-request
|
fitzgen
:
review+
|
Details |
https://treeherder.mozilla.org/logviewer.html#?job_id=7872601&repo=fx-team
PROCESS | 5211 | DevToolsUtils.assert threw an exception: Error: Assertion failure: Should be diffing when ending a census diff
PROCESS | 5211 | DevToolsUtils.assert threw an exception: Error: Assertion failure: Should be diffing when ending a census diff
PROCESS | 5211 | @@redux/middleware/task#error threw an exception: Error: Assertion failure: Should be diffing when ending a census diff
PROCESS | 5211 | @@redux/middleware/task#error threw an exception: Error: Assertion failure: Should be diffing when ending a census diff
PROCESS | 5211 | DevToolsUtils.assert threw an exception: Error: Assertion failure: Should be diffing when ending a census diff
PROCESS | 5211 | DevToolsUtils.assert threw an exception: Error: Assertion failure: Should be diffing when ending a census diff
PROCESS | 5211 | @@redux/middleware/task#error threw an exception: Error: Assertion failure: Should be diffing when ending a census diff
PROCESS | 5211 | @@redux/middleware/task#error threw an exception: Error: Assertion failure: Should be diffing when ending a census diff
Assignee | ||
Comment 1•9 years ago
|
||
Possible race condition if the census diff has not been completed when we attempt to clear all snapshots.
Now waiting explicitly for the TAKE_CENSUS_DIFF_END action before continuing the test.
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6911b8385660
Flags: needinfo?(jdescottes)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
Not sure how to trigger OSX 10.6 tests on try. Don't think my previous push will run anything.
Another try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9600858136d4
Comment 3•9 years ago
|
||
On trychooser, there's a "Restrict tests to platform" section where you can choose 10.6. You can also add jobs to an existing push from Treeherder via the dropdown on the right hand side - "add new jobs".
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
Thanks for the tips!
> On trychooser, there's a "Restrict tests to platform" section where you can
> choose 10.6.
That's how I built my query for the 2nd job. But I still was unsure about it. After checking 10.6 you still have to select a platform and I checked macosx64, randomly.
> You can also add jobs to an existing push from Treeherder via
> the dropdown on the right hand side - "add new jobs".
Actually did it with the first job. Since new jobs take a long time to appear, I thought it didn't work.
Just relaunched a few XPC shell tests in the second try push
: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6911b8385660
Assignee | ||
Comment 5•9 years ago
|
||
After enabling diff view and selecting two snapshots, wait for TAKE_CENSUS_DIFF_END
action in the test before deleting all snapshots. Otherwise, TAKE_CENSUS_DIFF_END
might be dispatched after clearSnapshots toggled diff mode off.
Review commit: https://reviewboard.mozilla.org/r/39451/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39451/
Attachment #8729455 -
Flags: review?(nfitzgerald)
Comment 6•9 years ago
|
||
Comment on attachment 8729455 [details]
MozReview Request: Bug 1254726 - fix intermittent test_action-clear-snapshots_06 (osx10.6);r=fitzgen
https://reviewboard.mozilla.org/r/39451/#review36157
::: devtools/client/memory/test/unit/test_action-clear-snapshots_06.js:47
(Diff revision 1)
> +
> ok(getState().diffing, "We should be in diffing view");
>
> + yield waitUntilAction(store, actions.TAKE_CENSUS_DIFF_END);
> + ok(true, "Received TAKE_CENSUS_DIFF_END action");
> +
Thanks! I should have caught this in the initial review :(
Attachment #8729455 -
Flags: review?(nfitzgerald) → review+
Comment 8•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•