1254729 - Remove about:devices from Fennec

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Nick Alexander :nalexander [he/him]]

This never got any love, so it's time for it to go.  It was added in Bug 1000676.

This ticket looks similar to reverting https://hg.mozilla.org/mozilla-central/rev/9935f6263940 and https://hg.mozilla.org/mozilla-central/rev/a76dad2f409d, plus a little bit more clean-up.

Comment 1

[Nick Alexander :nalexander [he/him]]

mfinkle: can you link this to a ticket for removing casting from Fennec entirely?

Comment 2

[:Grisha Kruglov]

Going to revert the changesets nalexander mentioned; Ok to kill off this page, Margaret?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Nick Alexander :nalexander from comment #1)
> mfinkle: can you link this to a ticket for removing casting from Fennec
> entirely?

Tab mirroring was (mostly) removed. Video casting remains.... for now.

about:devices can certainly be removed though. We never pushed it past the debugging phase.

Comment 4

[:Margaret Leibovic]

+1 from me, I didn't even know this page existed!

Comment 5

[:Grisha Kruglov]

Attachment: MozReview Request: Bug 1254729 - remove about:devices from Fennec (r=nalexander)

Review commit: https://reviewboard.mozilla.org/r/39009/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39009/

Comment 6

[:Grisha Kruglov]

Comment on attachment 8728663 [details]
MozReview Request: Bug 1254729 - remove about:devices from Fennec (r=nalexander)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39009/diff/1-2/

Comment 7

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8728663 [details]
MozReview Request: Bug 1254729 - remove about:devices from Fennec (r=nalexander)

https://reviewboard.mozilla.org/r/39009/#review35711

Looks good!  Push an (Android-only) try build before requesting checkin-needed, please.

Comment 8

[:Grisha Kruglov]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=671670a6f6d5

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing.

Comment 10

[:Grisha Kruglov]

Comment on attachment 8728663 [details]
MozReview Request: Bug 1254729 - remove about:devices from Fennec (r=nalexander)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39009/diff/2-3/

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5d2b412d2e7d

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5d2b412d2e7d

Comment 13

[Sorina Florean [:sflorean]]

Verified as fixed in build 48.0a2 2016-05-22;
Device: Asus Transformer Pad (Android 4.2.1) and Nexus 5 (Android 6.0.1).