Closed Bug 1254729 Opened 4 years ago Closed 4 years ago

Remove about:devices from Fennec

Categories

(Firefox for Android :: Screencasting, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 48
Tracking Status
firefox48 --- verified

People

(Reporter: nalexander, Unassigned, Mentored)

References

Details

(Whiteboard: [good next bug])

Attachments

(1 file)

This never got any love, so it's time for it to go.  It was added in Bug 1000676.

This ticket looks similar to reverting https://hg.mozilla.org/mozilla-central/rev/9935f6263940 and https://hg.mozilla.org/mozilla-central/rev/a76dad2f409d, plus a little bit more clean-up.
mfinkle: can you link this to a ticket for removing casting from Fennec entirely?
Mentor: nalexander
Flags: needinfo?(mark.finkle)
Whiteboard: [good next bug]
Going to revert the changesets nalexander mentioned; Ok to kill off this page, Margaret?
Flags: needinfo?(margaret.leibovic)
(In reply to Nick Alexander :nalexander from comment #1)
> mfinkle: can you link this to a ticket for removing casting from Fennec
> entirely?

Tab mirroring was (mostly) removed. Video casting remains.... for now.

about:devices can certainly be removed though. We never pushed it past the debugging phase.
Flags: needinfo?(mark.finkle)
+1 from me, I didn't even know this page existed!
Flags: needinfo?(margaret.leibovic)
Comment on attachment 8728663 [details]
MozReview Request: Bug 1254729 - remove about:devices from Fennec (r=nalexander)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39009/diff/1-2/
Comment on attachment 8728663 [details]
MozReview Request: Bug 1254729 - remove about:devices from Fennec (r=nalexander)

https://reviewboard.mozilla.org/r/39009/#review35711

Looks good!  Push an (Android-only) try build before requesting checkin-needed, please.
Attachment #8728663 - Flags: review?(nalexander) → review+
Keywords: checkin-needed
Comment on attachment 8728663 [details]
MozReview Request: Bug 1254729 - remove about:devices from Fennec (r=nalexander)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39009/diff/2-3/
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5d2b412d2e7d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Verified as fixed in build 48.0a2 2016-05-22;
Device: Asus Transformer Pad (Android 4.2.1) and Nexus 5 (Android 6.0.1).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.