Closed Bug 1254746 Opened 8 years ago Closed 8 years ago

Intermittent browser_service_workers_start.js | Found its debug button - and more

Categories

(DevTools :: about:debugging, defect, P1)

Product:
DevTools
Component:
about:debugging
Type:
defect

Tracking

(e10s+, firefox48 fixed, firefox49 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 49
Tracking Flags:
Tracking Status
e10s + ---
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: KWierso, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

patch v1
2.26 KB, patch
jryans
: review+
Details | Diff | Splinter Review
Priority: -- → P3
Upgrading to P1 because this intermittent blocks Linux Debug e10s tests (TaskCluster) from being enabled in production.
Priority: P3 → P1
Alex, could you please help with this bug? I won't be able to look into it too soon because I'll be away for a week.
Flags: needinfo?(poirot.alex)
oh, a week ago this bug wasn't an issue, now it seems like an issue on windows 7 (new VM instances we want to migrate to).  It would be nicer to get this fixed.
This is currently the top devtools orange
I think I got it. Let me push something to try.
Flags: needinfo?(poirot.alex)
Attached patch patch v1 — — Splinter Review 
I think the issue is related to this 1s timeout (SW_TIMEOUT)
which can easily end up killing the SW sooner than expected.
We will see the reported timeout if it takes more than 1s between
the document/worker load and this test line:
  ok(targetElement.querySelector(".debug-button"), "Found its debug button")
Which sounds very likely on slow machines...
Attachment #8757038 - Flags: review?(jryans)
Comment on attachment 8757038 [details] [diff] [review]
patch v1

Review of attachment 8757038 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/aboutdebugging/test/browser_service_workers_start.js
@@ +62,5 @@
>  
> +    // Wait for the service worker to be killed due to inactivity.
> +    yield waitForMutation(targetElement, { childList: true });
> +  } else {
> +    // Check that there is a Debug button but not a Start button.

Need to update this comment.
Attachment #8757038 - Flags: review?(jryans) → review+
https://hg.mozilla.org/integration/fx-team/rev/3ec632e7abe59aea06d037758ed90fbcd23d22a9
Bug 1254746 - Fix browser_service_workers_start.js intermittent when the worker is killed sooner than expected. r=jryans
https://hg.mozilla.org/mozilla-central/rev/3ec632e7abe5
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Thanks Alex!
Assignee: nobody → poirot.alex
status-firefox48: --- → affected
Whiteboard: [checkin-needed-beta]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: