Baldr: handle over-recursion in validator

RESOLVED FIXED in Firefox 48

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8728226 [details] [diff] [review]
fix-recursion

This won't be necessary after switching to iterative post-order decoding, but it is now.
Attachment #8728226 - Flags: review?(bbouvier)
Comment on attachment 8728226 [details] [diff] [review]
fix-recursion

Review of attachment 8728226 [details] [diff] [review]:
-----------------------------------------------------------------

Nice test case!

::: js/src/jit-test/tests/wasm/binary.js
@@ +42,5 @@
>  }
>  
>  function varU32(u32) {
> +    var bytes = [];
> +    assertEq(u32 < Math.pow(2,32), true);

Do we need to ensure u32 is positive too?
Attachment #8728226 - Flags: review?(bbouvier) → review+

Comment 3

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/404ff7069a35
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.