Closed
Bug 1254836
Opened 10 years ago
Closed 10 years ago
Baldr: handle over-recursion in validator
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: luke, Assigned: luke)
Details
Attachments
(1 file)
|
3.29 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
This won't be necessary after switching to iterative post-order decoding, but it is now.
Attachment #8728226 -
Flags: review?(bbouvier)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8728226 [details] [diff] [review]
fix-recursion
Review of attachment 8728226 [details] [diff] [review]:
-----------------------------------------------------------------
Nice test case!
::: js/src/jit-test/tests/wasm/binary.js
@@ +42,5 @@
> }
>
> function varU32(u32) {
> + var bytes = [];
> + assertEq(u32 < Math.pow(2,32), true);
Do we need to ensure u32 is positive too?
Attachment #8728226 -
Flags: review?(bbouvier) → review+
|
||
Comment 3•10 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•