1254866 - ReferenceError: Cu is not defined in ext-i18n.js

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Tommy Kuo (away forever...)]

In this line:
https://dxr.mozilla.org/mozilla-central/source/toolkit/components/extensions/ext-i18n.js#3

Cu is not declared and the ReferenceError happened.

Comment 1

[Tommy Kuo (away forever...)]

Attachment: Bug-1254866-hg.patch

Hi kmag, could you review the patch? Without this patch, b2g cannot boot up.

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8728266 [details] [diff] [review]
Bug-1254866-hg.patch

Review of attachment 8728266 [details] [diff] [review]:
-----------------------------------------------------------------

Hm. It should inherit that variable from the Extension.jsm scope. I guess this has something to do with a quirk of the b2g module loader?

::: toolkit/components/extensions/ext-i18n.js
@@ +1,3 @@
>  "use strict";
>  
> +const Cu = Components.utils;

Can you change this to match the other modules?

var {classes: Cc, interfaces: Ci, utils: Cu} = Components;

Comment 3

[Tommy Kuo (away forever...)]

Attachment: Bug-1254866-hg.patch

Hi, kmag! I updated the patch with your suggestion.

But I think we use Cu only. Should we declare other variables like Cc and Ci?

Comment 4

[Kris Maglione [:kmag]]

(In reply to Tommy Kuo [:KuoE0] from comment #3)
> But I think we use Cu only. Should we declare other variables like Cc and Ci?

Yes. If we don't, someone will wind up adding code that uses them in the future, and b2g will break again.

Comment 5

[Tommy Kuo (away forever...)]

Try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=720ae78f21e5

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7e4686be6b1f

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb2b11e74142

Comment 8

[Kris Maglione [:kmag]]

The bug will be closed automatically when this merges to mozilla-central.

I'm not sure why this was landed to both inbound and fx-team...

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7e4686be6b1f

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cb2b11e74142