bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

If text chat consists of entirely context tiles, then it doesn't automatically scroll

RESOLVED FIXED

Status

Hello (Loop)
Client
P1
normal
Rank:
18
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [btpp-fix-now])

Attachments

(1 attachment)

STR:

1) Set up a conversation between two people.
2) On the link generator side, switch between two tabs with pages loaded from different domains.
3) What the text chat on each side.

Expected Results

=> When the tiles fill the text chat area it should scroll automatically.

Actual Results

=> Scrolling doesn't happen. It only happens if there are actual text chat messages.
Rank: 18
Whiteboard: [btpp-fix-now]
Created attachment 8728381 [details] [review]
[loop] Standard8:bug-1254945-scroll > mozilla:master
Comment on attachment 8728381 [details] [review]
[loop] Standard8:bug-1254945-scroll > mozilla:master

I went for changing the sense of the operation, so that if we add more context types, then we don't have add them all individually.

Also added some tests, and added an additional test for making sure the code that displays the ContextUrlView in the TextChatView#render function gets called.
Attachment #8728381 - Flags: review?(b.mcb)
Comment on attachment 8728381 [details] [review]
[loop] Standard8:bug-1254945-scroll > mozilla:master

Looks good. r=me
Attachment #8728381 - Flags: review?(b.mcb) → review+
https://github.com/mozilla/loop/commit/f8b372e0f8ae65368de5c0c101c6be0e12282fd8
Status: NEW → RESOLVED
Iteration: --- → 48.1 - Mar 21
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.