1254958 - browser_mozLoop_telemetry.js fails due to not resetting prefs

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

I tried exporting master yesterday as Dave and I were testing a new mochitests, and we came across the fact that browser_mozLoop_telemetry.js is failing:

564 INFO TEST-UNEXPECTED-FAIL | browser/extensions/loop/chrome/test/mochitest/browser_mozLoop_telemetry.js | LOOP_MAU_TYPE.OPEN_PANEL - 0 === 1 - JS frame :: chrome://mochitests/content/browser/browser/extensions/loop/chrome/test/mochitest/browser_mozLoop_telemetry.js :: test_mozLoop_telemetryAdd_loopMauType_buckets :: line 172
565 INFO TEST-UNEXPECTED-FAIL | browser/extensions/loop/chrome/test/mochitest/browser_mozLoop_telemetry.js | LOOP_MAU_TYPE.OPEN_CONVERSATION - 0 === 1 - JS frame :: chrome://mochitests/content/browser/browser/extensions/loop/chrome/test/mochitest/browser_mozLoop_telemetry.js :: test_mozLoop_telemetryAdd_loopMauType_buckets :: line 174
566 INFO TEST-UNEXPECTED-FAIL | browser/extensions/loop/chrome/test/mochitest/browser_mozLoop_telemetry.js | LOOP_MAU_TYPE.OPEN_PANEL - 0 === 1 - JS frame :: chrome://mochitests/content/browser/browser/extensions/loop/chrome/test/mochitest/browser_mozLoop_telemetry.js :: test_mozLoop_telemetryAdd_loopMau_more_than_30_days :: line 196
567 INFO TEST-UNEXPECTED-FAIL | browser/extensions/loop/chrome/test/mochitest/browser_mozLoop_telemetry.js | LOOP_MAU_TYPE.OPEN_PANEL - 1 === 2 - JS frame :: chrome://mochitests/content/browser/browser/extensions/loop/chrome/test/mochitest/browser_mozLoop_telemetry.js :: test_mozLoop_telemetryAdd_loopMau_more_than_30_days :: line 205

The issue appears to be that the prefs aren't always reset before and between tests. I'll have a patch up in a few.

Comment 1

[GitHub Autolander Bot]

Attachment: [loop] Standard8:bug-1254958-mau > mozilla:master

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8728388 [details] [review]
[loop] Standard8:bug-1254958-mau > mozilla:master

This probably goes a bit over the top with resetting prefs, but it'll ensure that they are all the expected values for the tests and any that get added later.

Comment 3

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8728388 [details] [review]
[loop] Standard8:bug-1254958-mau > mozilla:master

r=me. Thanks for the quick fix

Comment 4

[Mark Banner (:standard8)]

https://github.com/mozilla/loop/commit/bcca86d110993b827b279617d1a0484d1940c0cd