1254989 - extend TreeWalker::Next to accept a stopper node

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8728409 [details] [diff] [review]
patch

Review of attachment 8728409 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, just 1 question..

::: accessible/base/TreeWalker.cpp
@@ +223,2 @@
>        bool skipSubtree = false;
> +      Accessible* child = AccessibleFor(childNode, eWalkCache, &skipSubtree);

Can we now step into GetOrCreateAccessible in AccessibleFor ?
just looking at the comment above // No accessible creation on the way back.

Comment 2

[alexander :surkov (:asurkov)]

no, in case of eWalkCache

Comment 3

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/150a27aadfd348bbb0c5e3da2fe6dfb03140edfe
Bug 1254989 - extend TreeWalker::Next to accept a stopper node, r=yzen

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/150a27aadfd3