1254999 - new "couldn't find fileUrl" exception

Status: RESOLVED WONTFIX

(Release Engineering Graveyard :: Applications: Balrog (backend), defect, P3)

Description

[[e-mail] (:bhearsum)]

Attachment: Firefox-46.0b1-build4.json

Traceback (most recent call last):
File "/data/www/aus4.mozilla.org/app/vendor/lib/python/flask/app.py", line 1475, in full_dispatch_request rv = self.dispatch_request()
File "/data/www/aus4.mozilla.org/app/vendor/lib/python/flask/app.py", line 1461, in dispatch_request return self.view_functions[rule.endpoint](**req.view_args)
File "/usr/lib64/python2.6/site-packages/newrelic-2.44.0.36/newrelic/hooks/framework_flask.py", line 40, in _nr_wrapper_handler_ return wrapped(*args, **kwargs)
File "/data/www/aus4.mozilla.org/app/vendor/lib/python/flask/views.py", line 84, in view return self.dispatch_request(*args, **kwargs)
File "/data/www/aus4.mozilla.org/app/vendor/lib/python/flask/views.py", line 149, in dispatch_request return meth(*args, **kwargs)
File "/data/www/aus4.mozilla.org/app/auslib/web/views/client.py", line 55, in get xml = release.createXML(query, update_type, app.config["WHITELISTED_DOMAINS"], app.config["SPECIAL_FORCE_HOSTS"])
File "/data/www/aus4.mozilla.org/app/auslib/blobs/apprelease.py", line 135, in createXML patches = self._getPatchesXML(localeData, updateQuery, whitelistedDomains, specialForceHosts)
File "/data/www/aus4.mozilla.org/app/auslib/blobs/apprelease.py", line 485, in _getPatchesXML xml = self._getSpecificPatchXML(patchKey, patchType, patch, updateQuery, whitelistedDomains, specialForceHosts)
File "/data/www/aus4.mozilla.org/app/auslib/blobs/apprelease.py", line 86, in _getSpecificPatchXML url = self._getUrl(updateQuery, patchKey, patch, specialForceHosts)
File "/data/www/aus4.mozilla.org/app/auslib/blobs/apprelease.py", line 555, in _getUrl raise ValueError("Couldn't find fileUrl")
ValueError: Couldn't find fileUrl

This started with 46.0b1 (the first Release Promotion release), so it's probably submitting some data that Balrog finds weird. Attached is the 46.0b1 blob. The fix will probably involve one or both of the following:
* Make sure we don't allow bad data (if that's the cause) into the system
* Make sure we catch exceptions in this scenario

Comment 1

[[e-mail] (:bhearsum)]

Looks like this one isn't new after all...I was looking at the wrong time slice in newrelic. It's been happening for well over a week, probably much longer (newrelic doesn't store errors for a super long time...).

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

I was trying to find some recent errors in newrelic to trace the request, but it seems to have occurred between Mar 9, 7:53 and Mar 10, 06:34 AM Pacific. 

The structure of fileURLs in Firefox-46.0b1-build4 is unusual in that it has entries for *, beta, beta-cdntest and beta-localtest, while 46.0b1 build8 and 46.0b2 build3 just have * and beta-localtest. Perhaps something related to shaking out bugs with release promotion.