Closed Bug 1255005 Opened 8 years ago Closed 8 years ago

Don't log host info unless a failure is detected

Categories

(Firefox for Android Graveyard :: Testing, defect)

defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Android emulator test jobs log "ps" and "netstat" output from the host. That might be useful information on occasion, but it is almost always the same and has not aided any diagnostic efforts in recent months. Let's turn it off, at least when emulator startup looks OK.
The only functional change here is moving the call to _dump_host_state() so that less is logged on success.

I noticed several instances of unused code -- cleaned those up too.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac843abb37a5 -- nothing broken.
Attachment #8728444 - Flags: review?(kmoir)
Attachment #8728444 - Flags: review?(kmoir) → review+
https://hg.mozilla.org/mozilla-central/rev/e83b73ce4d1a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Blocks: logspam
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: