Closed
Bug 1255013
Opened 8 years ago
Closed 8 years ago
Tag "disqualified" cohorts in e10s staged rollout add-on
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 48
People
(Reporter: Felipe, Assigned: Felipe)
References
Details
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
mossop
:
review+
lizzard
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta+
|
Details |
From bug 1251259 comment 13, to help analyze the data. We'll need to duplicate some of the logic from nsAppRunner, but I think that's better than having to deal with it during data analysis.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40517/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40517/
Attachment #8731345 -
Flags: review?(dtownsend)
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8731345 [details] MozReview Request: Bug 1255013 - Tag disqualified cohorts in e10s staged rollout. r=Mossop Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40517/diff/1-2/
Comment 3•8 years ago
|
||
Comment on attachment 8731345 [details] MozReview Request: Bug 1255013 - Tag disqualified cohorts in e10s staged rollout. r=Mossop https://reviewboard.mozilla.org/r/40517/#review37099
Attachment #8731345 -
Flags: review?(dtownsend) → review+
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5b23762829ad
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8731345 [details] MozReview Request: Bug 1255013 - Tag disqualified cohorts in e10s staged rollout. r=Mossop Approval Request Comment [Feature/regressing bug #]: uses the code added by bug 1257242. Very important to tag "disqualified" cohorts in the data, as requested in bug 1251259 comment 13. [User impact if declined]: Disqualified users will be mixed with test/control users and will need to be filtered somehow during data analysis. [Describe test coverage new/current, TreeHerder]: landed on central, QA'ed by softvision [Risks and why]: no risk on this patch, it would all be contained on bug 1257242 [String/UUID change made/needed]: none
Attachment #8731345 -
Flags: approval-mozilla-beta?
Attachment #8731345 -
Flags: approval-mozilla-aurora?
Comment 7•8 years ago
|
||
Comment on attachment 8731345 [details] MozReview Request: Bug 1255013 - Tag disqualified cohorts in e10s staged rollout. r=Mossop OK to land this for beta 4, needed for e10s staged rollout
Attachment #8731345 -
Flags: approval-mozilla-beta?
Attachment #8731345 -
Flags: approval-mozilla-beta+
Attachment #8731345 -
Flags: approval-mozilla-aurora?
Attachment #8731345 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 8•8 years ago
|
||
http://hg.mozilla.org/releases/mozilla-aurora/rev/3fc13868be73 http://hg.mozilla.org/releases/mozilla-beta/rev/e093539be413
status-firefox46:
--- → fixed
status-firefox47:
--- → fixed
Comment 9•8 years ago
|
||
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
You need to log in
before you can comment on or make changes to this bug.
Description
•