Closed
Bug 1255025
Opened 10 years ago
Closed 10 years ago
Empty state missing from Top-Sites
Categories
(Firefox for iOS :: Home screen, defect)
Tracking
()
VERIFIED
FIXED
4.0
People
(Reporter: aaronmt, Assigned: bmunar)
Details
(Keywords: reproducible, Whiteboard: [needstrings])
Attachments
(4 files)
emptiness.png
Currently there is no empty state message on an empty Top Sites panel.
|
||
Updated•10 years ago
|
|
|
||
Comment 1•10 years ago
|
||
Flags: needinfo?(randersen)
|
|
||
Comment 2•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → bmunar
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8734079 -
Flags: ui-review?(randersen)
Attachment #8734079 -
Flags: review?(bnicholson)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8734079 [details] [review]
PR
I think the code looks mostly OK, but let's use NSLocalizedString with value here.
Attachment #8734079 -
Flags: review?(bnicholson) → feedback+
|
|
||
Updated•10 years ago
|
Attachment #8734079 -
Flags: feedback+ → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.0
|
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8734079 [details] [review]
PR
>https://github.com/mozilla/firefox-ios/pull/1660
Attachment #8734079 -
Flags: ui-review?(randersen) → ui-review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•