1255110 - Migrate mozIntl.DateTimeFormat to Intl.DateTimeFormat.formatToParts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Since we now have DateTimeFormat.prototype.formatToParts in Gecko, we should migrate Gaia to use it and remove mozIntl.DateTimeFormat.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1255110-migrate-to-formattoparts > mozilla-b2g:master

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8728620 [details] [review]
[gaia] zbraniecki:1255110-migrate-to-formattoparts > mozilla-b2g:master

Stas, can you review this for me?

Comment 3

[Staś Małolepszy :stas]

Comment on attachment 8728620 [details] [review]
[gaia] zbraniecki:1255110-migrate-to-formattoparts > mozilla-b2g:master

LGTM, thanks, Zibi!

Just a nit about Array.reduce:  you may want to change:

  .reduce((string, part) => string + part, '');

to the equivalent:

  .reduce((string, part) => string + part);

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Unfortunately, I cannot do that.

formatToParts may return an empty array and in that case, reduce will error because original string is undefined.

In order cover that scenario, we need the second argument on reduce to be an empty string.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/175c2f208c92a9ebdef943715621cdac2bda81c1

Comment 6

[Staś Małolepszy :stas]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #4)
> Unfortunately, I cannot do that.
> 
> formatToParts may return an empty array and in that case, reduce will error
> because original string is undefined.

Ah, I didn't realize this was possible, thanks!  Out of curiosity, in what cases would formatToParts return an empty array?

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

When Intl can't find a matching pattern in selected language. Each language may have different coverage of patterns (although at the moment I think that's rare). 

An example combo that works in the current Firefox is:

(new Date()).toLocaleString('en-US', {era: 'long', day: '2-digit'});

Comment 8

[Alberto Pastor [:albertopq]]

Ey :gandalf! It seems that GU3 started failing after this commit:

TEST-UNEXPECTED-FAIL | null | [calendar-test/unit/views/current_time_test.js] Views.CurrentTime #_render should update position and time
TypeError: formatter.formatToParts is not a function 

Is there anything missing in the test? Thanks!

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Yeah! Thank you for finding it!

Fixed: https://github.com/mozilla-b2g/gaia/commit/355baa0efee94e9c6f7aea4b3935060753831d01