1255165 - TypeArray.prototype.set needs a better error message than "invalid array length".

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicolas B. Pierron [:nbp]]

While documenting "invalid array length" [1] error, I noticed that we have the same error for TypeArray.prototype.set[2] function.

I think TypeArray.prototype.set needs a better error message when the origin is larger than the remaining space of the target.

In SpiderMonkey:
> var t = new Uint32Array(1);
> var t2 = new Uint32Array(3);
> t.set(t2)
RangeError: invalid array length


In v8:
> var t = new Uint32Array(1);
> var t2 = new Uint32Array(3);
> t.set(t2)
RangeError: Source is too large


Also, this error does not seems to be documented on the TypedArray.prototype.set page.


[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Invalid_array_length
[1] https://dxr.mozilla.org/mozilla-central/source/js/src/vm/TypedArrayCommon.h#819,831
[2] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/set

Comment 1

[Aditya S]

Can I work on this bug?

Comment 2

[Tooru Fujisawa [:arai]]

sure

Comment 3

[Tooru Fujisawa [:arai]]

I suppose you've commented to the wrong bug.

anyway,
Required code changes are following:
  * Add a new error message for the case when the source array's length is too long [1]
  * Modify TypedArrayObject::set_impl [2] to throw the new error for the cases [3][4]

You'll need basic knowledge of C++, and be able to build and test Firefox [5] or SpiderMonkey [6].

[1] https://searchfox.org/mozilla-central/rev/f0c15db995198a1013e1c5f5b5bea54ef83f1049/js/src/js.msg#552
[2] https://searchfox.org/mozilla-central/rev/f0c15db995198a1013e1c5f5b5bea54ef83f1049/js/src/vm/TypedArrayObject.cpp#1470
[3] https://searchfox.org/mozilla-central/rev/f0c15db995198a1013e1c5f5b5bea54ef83f1049/js/src/vm/TypedArrayObject.cpp#1539
[4] https://searchfox.org/mozilla-central/rev/f0c15db995198a1013e1c5f5b5bea54ef83f1049/js/src/vm/TypedArrayObject.cpp#1577
[5] https://developer.mozilla.org/en-US/docs/Simple_Firefox_build
[6] https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Build_Documentation

Comment 4

[Aditya S]

ok thanks

Comment 5

[Vincent Lequertier]

Hi, can I work on this? :-)

Vincent

Comment 6

[Tooru Fujisawa [:arai]]

yes :)
see the comment #3 for the details.
feel free to ask question here, or #jsapi IRC channel

Comment 7

[Vincent Lequertier]

Thanks!

Comment 8

[Vincent Lequertier]

Attachment: Bug 1255165 - Improve error message for TypeArray.prototype.set if source array is too large;r=arai

Comment 9

[Tooru Fujisawa [:arai]]

here's try run
https://treeherder.mozilla.org/#/jobs?repo=try&revision=941e1dbfd00a435f49d6fb7b4a498273bc6dc6e4

once it finishes without any issue, you can add "checkin-needed" to keyword field, so that your patch will be landed.

Comment 10

[Vincent Lequertier]

Thanks! I have added the label as the test failures seem only intermittent.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26d207ba289e
Improve error message for TypeArray.prototype.set if source array is too large;r=arai

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/26d207ba289e