Minor cleanups in test_wheel_default_action.html

RESOLVED FIXED in Firefox 48

Status

()

Core
DOM: Events
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
I noticed a few minor issues while looking at this test.

I also wrote a few refactorings to make it easier to what is understanding with the asynchrony, but I don't know if it is worth landing those, so I'll skip them for now.
(Assignee)

Comment 1

2 years ago
Created attachment 8728705 [details] [diff] [review]
part 1 - Remove a leftover use of clearUserPref.

Also, remove some trailing whitespace.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed14a344e2b2
Attachment #8728705 - Flags: review?(masayuki)
(Assignee)

Comment 2

2 years ago
Created attachment 8728706 [details] [diff] [review]
part 2 - Remove extraneous argument to sendWheelAndWait.

Bug 1140293 changed hitEventLoop calls to sendWheelAndWait but did not remove the extra argument.
Attachment #8728706 - Flags: review?(masayuki)
Attachment #8728705 - Flags: review?(masayuki) → review+
Attachment #8728706 - Flags: review?(masayuki) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3557a7a3736b
https://hg.mozilla.org/mozilla-central/rev/22cbefa8f1d2
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.