Closed Bug 1255192 Opened 8 years ago Closed 8 years ago

Remove the JSContext argument of ExceptionStackOrNull

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(2 files)

It's not needed.
Comment on attachment 8728650 [details] [diff] [review]
part 2.  Clean up the JSContext usage around xpc::FindExceptionStackForConsoleReport now that iy just needs a JSContext for rooting

Review of attachment 8728650 [details] [diff] [review]:
-----------------------------------------------------------------

nit: typo in patch description.
Attachment #8728650 - Flags: review?(bobbyholley) → review+
Comment on attachment 8728644 [details] [diff] [review]
part 1.  Remove the JSContext argument of JS::ExceptionStackOrNull

Review of attachment 8728644 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing this one. Seems fine.
Attachment #8728644 - Flags: review?(efaustbmo) → review+
https://hg.mozilla.org/mozilla-central/rev/c1072d4efaae
https://hg.mozilla.org/mozilla-central/rev/412c5cae8dea
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: