Closed
Bug 1255192
Opened 8 years ago
Closed 8 years ago
Remove the JSContext argument of ExceptionStackOrNull
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(2 files)
3.90 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
8.49 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
It's not needed.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8728644 -
Flags: review?(efaustbmo)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8728650 -
Flags: review?(bobbyholley)
Comment 3•8 years ago
|
||
Comment on attachment 8728650 [details] [diff] [review] part 2. Clean up the JSContext usage around xpc::FindExceptionStackForConsoleReport now that iy just needs a JSContext for rooting Review of attachment 8728650 [details] [diff] [review]: ----------------------------------------------------------------- nit: typo in patch description.
Attachment #8728650 -
Flags: review?(bobbyholley) → review+
Comment 4•8 years ago
|
||
Comment on attachment 8728644 [details] [diff] [review] part 1. Remove the JSContext argument of JS::ExceptionStackOrNull Review of attachment 8728644 [details] [diff] [review]: ----------------------------------------------------------------- Stealing this one. Seems fine.
Attachment #8728644 -
Flags: review?(efaustbmo) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1072d4efaae https://hg.mozilla.org/integration/mozilla-inbound/rev/412c5cae8dea
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c1072d4efaae https://hg.mozilla.org/mozilla-central/rev/412c5cae8dea
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•