1255201 - Improve the stack handling in nsXPCComponents_Utils::ReportError for the DOMException case

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We can get a stack in that case too.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Improve the stack handling in nsXPCComponents_Utils::ReportError for the DOMException case to include the stack from the DOMException

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 8728658 [details] [diff] [review]
Improve the stack handling in nsXPCComponents_Utils::ReportError for the DOMException case to include the stack from the DOMException

Review of attachment 8728658 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry this one got lost.

::: dom/base/nsJSUtils.cpp
@@ +77,5 @@
>    return nativeGlobal->GetScriptContext();
>  }
>  
> +nsPIDOMWindowInner *
> +nsJSUtils::GetCurrentlyRunningCodeInnerWindow(JSContext *aContext)

This duplicates CurrentWindowOrNull, right?

Comment 3

[Boris Zbarsky [:bzbarsky]]

> This duplicates CurrentWindowOrNull, right?

Except in the null JSContext case, you're right.  Good catch.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Improve the stack handling in nsXPCComponents_Utils::ReportError for the DOMException case to include the stack from the DOMException

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/82e7e34cedc5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/82e7e34cedc5