[Narrate] Don't skip to next section by stop and start

VERIFIED FIXED in Firefox 49

Status

()

Toolkit
Reader Mode
P5
normal
VERIFIED FIXED
2 years ago
a year ago

People

(Reporter: magicp, Assigned: eeejay)

Tracking

48 Branch
mozilla51
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox48 unaffected, firefox49 verified, firefox50 verified, firefox51 verified)

Details

(Whiteboard: [reader-mode-narrate])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160309030419

Steps to reproduce:

1. Start Nightly
2. Go to "https://developer.mozilla.org/Firefox"
3. Switch to reader mode
4. Open narrate-control
5. Click "Start"
6. Click "Stop" and "Start"



Actual results:

In step 6, skip to next section. 


Expected results:

Start from stopped position.
(Reporter)

Updated

2 years ago
Has STR: --- → yes
status-firefox48: --- → affected
OS: Unspecified → All
Hardware: Unspecified → All

Updated

2 years ago
Priority: -- → P5
Whiteboard: [reader-mode-narrate]
Eitan, is this on your radar? How difficult would it be to fix this?
Flags: needinfo?(eitan)
(Reporter)

Updated

2 years ago
status-firefox49: --- → affected
status-firefox50: --- → affected
status-firefox51: --- → affected
(Assignee)

Comment 2

2 years ago
Created attachment 8777503 [details]
Bug 1255261 - Read current paragraph after pressing stop.

We always had to make sure we were one paragraph back from where we wanted
to start. That seems broken. I made it so that we start from the current
paragraph.

Review commit: https://reviewboard.mozilla.org/r/69040/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69040/
Attachment #8777503 - Flags: review?(jaws)
(Assignee)

Updated

2 years ago
Duplicate of this bug: 1291701
(Assignee)

Updated

2 years ago
Flags: needinfo?(eitan)
Assignee: nobody → eitan
Status: NEW → ASSIGNED
Comment on attachment 8777503 [details]
Bug 1255261 - Read current paragraph after pressing stop.

https://reviewboard.mozilla.org/r/69040/#review66804
Attachment #8777503 - Flags: review?(jaws) → review+
Comment hidden (mozreview-request)

Comment 6

2 years ago
Eitan, seems this was never autolanded, mozreview says:

 We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rewritecommitdescriptions --descriptions=/tmp/tmpx7ttLo 4c30cda8d1a9a8a6c2deff370a4c84fe28191bed: rebasing 339664:489ce1e6d656 "Bug 1255261 - Read current paragraph after pressing stop. r=jaws" (tip)

merging toolkit/components/narrate/Narrator.jsm merging toolkit/components/narrate/test/browser_narrate.js
warning: conflicts while merging toolkit/components/narrate/test/browser_narrate.js!
Flags: needinfo?(eitan)

Comment 7

2 years ago
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d29c0af9420d
Read current paragraph after pressing stop. r=jaws
(Assignee)

Comment 8

2 years ago
Weird, I rebased before I repushed to mozreview. Anyway, pushed manually to inbound now..
Flags: needinfo?(eitan)

Comment 9

2 years ago
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2069e3662c13
Followup - fix eslint error. CLOSED TREE

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d29c0af9420d
https://hg.mozilla.org/mozilla-central/rev/2069e3662c13
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51

Comment 11

2 years ago
Testday 12th August 2016 reference 1. Text to Speech in Reader Mode Test case 4.1.4. - FAIL.  I encountered this bug during testing. 

This bug is NOT resolved in Firefox 49.0b3 . While for theose with normal vision its a mere inconvenience, it could be a nasty and confusing bug from the point of view of the seriously visually impaired, who may have difficulty finding their way back to where the text breaks take place. Personally I'd rate this bug as Serious.

Comment 12

2 years ago
(In reply to ithompson4 from comment #11)
> Testday 12th August 2016 reference 1. Text to Speech in Reader Mode Test
> case 4.1.4. - FAIL.  I encountered this bug during testing. 
> 
> This bug is NOT resolved in Firefox 49.0b3 . While for theose with normal
> vision its a mere inconvenience, it could be a nasty and confusing bug from
> the point of view of the seriously visually impaired, who may have
> difficulty finding their way back to where the text breaks take place.
> Personally I'd rate this bug as Serious.

It isn't marked as fixed in 49. It has been addressed in 51, and is marked as such in the bug. In other words, what you're seeing is expected. In order to be addressed for 49, it would need uplifting. Eitan, want to uplift this?
Flags: needinfo?(eitan)
(Assignee)

Comment 13

2 years ago
Comment on attachment 8777503 [details]
Bug 1255261 - Read current paragraph after pressing stop.

Approval Request Comment
[Feature/regressing bug #]: 1255261
[User impact if declined]: Pressing stop narrate and then start again will no read from the last paragraph.
[Describe test coverage new/current, TreeHerder]: Added browser test.
[Risks and why]: A bit of a reworked narrate logic, so there is some risk but it is not high.
[String/UUID change made/needed]: None.
Flags: needinfo?(eitan)
Attachment #8777503 - Flags: approval-mozilla-beta?
Attachment #8777503 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

2 years ago
Duplicate of this bug: 1294745

Updated

2 years ago
Version: Trunk → 48 Branch
Hello, could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!
Flags: needinfo?(magicp.jp)
(Reporter)

Comment 16

2 years ago
I have verified this issue was fixed as expected (Read current paragraph after pressing stop) on Nightly build (20160815030201)
status-firefox51: fixed → verified
Flags: needinfo?(magicp.jp)
(In reply to magicp from comment #16)
> I have verified this issue was fixed as expected (Read current paragraph
> after pressing stop) on Nightly build (20160815030201)

Fantastic! Thank you. :)
Status: RESOLVED → VERIFIED
Comment on attachment 8777503 [details]
Bug 1255261 - Read current paragraph after pressing stop.

Fix was verified on Nightly, let's uplift to Aurora50.
Attachment #8777503 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 19

2 years ago
This feature is not available in the release channel. So changing to "unaffected".
status-firefox48: affected → unaffected
Needs rebasing for Aurora uplift.
Flags: needinfo?(eitan)
(Assignee)

Comment 21

2 years ago
Created attachment 8782536 [details] [diff] [review]
Read current paragraph after pressing stop (rebased for aurora).

This is a rebased patch for aurora.
(Assignee)

Comment 22

2 years ago
Comment on attachment 8782536 [details] [diff] [review]
Read current paragraph after pressing stop (rebased for aurora).

Same patch that was already approved, just rebased.

Sorry. Don't know how to do this within mozreview.
Flags: needinfo?(eitan)
Attachment #8782536 - Flags: approval-mozilla-aurora?
Comment on attachment 8782536 [details] [diff] [review]
Read current paragraph after pressing stop (rebased for aurora).

You don't need to re-request approval on simple rebases.
Attachment #8782536 - Flags: approval-mozilla-aurora?

Comment 24

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/84b11aee0b43
status-firefox50: affected → fixed
Comment on attachment 8777503 [details]
Bug 1255261 - Read current paragraph after pressing stop.

Fix for accessibility reader mode regression in 49, let's uplift this for beta 6.
Attachment #8777503 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 26

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/e6d6eb0ce3c4
status-firefox49: affected → fixed
Flags: qe-verify+
Verified fixed on Windows 7 x64, Mac OSX 10.9.5 and Ubuntu 16.04 x64 using latest Nightly 51.0a1 (buildID: 20160830030201), latest Aurora 50.0a2 (buildID: 20160831004001) and Firefox 49 Beta 8 (buildID: 20160829102229)
status-firefox49: fixed → verified
status-firefox50: fixed → verified

Updated

a year ago
Blocks: 1294711

Updated

a year ago
No longer blocks: 1294711
Duplicate of this bug: 1294711
You need to log in before you can comment on or make changes to this bug.