Closed Bug 1255283 Opened 10 years ago Closed 10 years ago

Improve the correctness of EXT_disjoint_timer_query test

Categories

(Core :: Graphics: CanvasWebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: jrmuizel, Unassigned)

Details

(Whiteboard: gfx-noted)

Attachments

(1 file)

This is needed for us to pass on windows. There are two main changes: 1. Spin the event loop before asking for availability 2. Only test TIMESTAMP_EXT if it is supported. (It's not with D3D11)
Attachment #8728794 - Attachment is patch: true
Attachment #8728794 - Flags: review?(jgilbert)
Comment on attachment 8728794 [details] [diff] [review] Improve the correctness of EXT_disjoint_timer_query test Review of attachment 8728794 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/canvas/test/webgl-mochitest/test_webgl_disjoint_timer_query.html @@ +13,5 @@ > <script> > > +function defer(f) > +{ > + setTimeout(f, 0); window.postMessage also works. @@ +57,5 @@ > + var timestampQuery = ext.createQueryEXT(); > + ext.queryCounterEXT(timestampQuery, ext.TIMESTAMP_EXT); > + gl.flush(); > + defer(function() { > + ok(ext.getQueryObjectEXT(timestampQuery, ext.QUERY_RESULT_AVAILABLE_EXT), Indent the deferred bits please. It's still mildly important for it to be readable.
Attachment #8728794 - Flags: review?(jgilbert) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: