1255303 - Use SurfaceFormat::B8G8R8X8 in BasicCompositor::CreateRenderTarget() if possible

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

BasicCompositor::CreateRenderTarget() always create draw target as SurfaceFormat::B8G8R8A8.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use SurfaceFormat::B8G8R8X8 in BasicCompositor::CreateRenderTarget() if possible

Comment 2

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c0619afe3fe

Comment 3

[Sotaro Ikeda [:sotaro]]

With talking with jeff, we are going to move CreateRenderTarget() for window to widget.

Comment 4

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #3)
> With talking with jeff, we are going to move CreateRenderTarget() for window
> to widget.

I changed my mind. BasicCompositor composites not only to widget's screen, but also for making Snapshot. To handle both cases, it seems better to keep the code in BasicCompositor in this bug.

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use SurfaceFormat::B8G8R8X8 as back buffer in BasicCompositor if possible

Comment 6

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b01830be4d0c

Comment 7

[Jeff Muizelaar [:jrmuizel]]

(In reply to Sotaro Ikeda [:sotaro] from comment #4)
> (In reply to Sotaro Ikeda [:sotaro] from comment #3)
> > With talking with jeff, we are going to move CreateRenderTarget() for window
> > to widget.
> 
> I changed my mind. BasicCompositor composites not only to widget's screen,
> but also for making Snapshot. To handle both cases, it seems better to keep
> the code in BasicCompositor in this bug.

What do you still plan to move things into widget? I don't think we want to be doing our weird DIBSection as an image surface business in CreateBackBufferRenderTargetForWindow.

Comment 8

[Sotaro Ikeda [:sotaro]]

Okey, I am going to include it in a next patch.

Comment 9

[Sotaro Ikeda [:sotaro]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #7)
> What do you still plan to move things into widget? I don't think we want to
> be doing our weird DIBSection as an image surface business in
> CreateBackBufferRenderTargetForWindow.

Yes, I am going to plan DIBSection thing in widget. I just put off the thing to another bugs like Bug 1254897 and Bug 1255703.

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use SurfaceFormat::B8G8R8X8 as back buffer if possible

Comment 11

[Sotaro Ikeda [:sotaro]]

attachment 8731089 [details] [diff] [review] moved a back buffer allocation to widget.

Comment 12

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use SurfaceFormat::B8G8R8X8 as back buffer if possible

update nits.

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d916e4520180

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d916e4520180

Comment 15

[Sotaro Ikeda [:sotaro]]

It causes Bug 1258094.

Comment 16

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use SurfaceFormat::B8G8R8X8 as back buffer if possible

Rebased.

Comment 17

[Sotaro Ikeda [:sotaro]]

Going to re-check in since bug 1255703 is addressed.

Comment 18

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/76361667f62b

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/76361667f62b