Use SurfaceFormat::B8G8R8X8 in BasicCompositor::CreateRenderTarget() if possible

RESOLVED FIXED in Firefox 48

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

(Blocks: 1 bug)

unspecified
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Assignee)

Description

3 years ago
BasicCompositor::CreateRenderTarget() always create draw target as SurfaceFormat::B8G8R8A8.
(Assignee)

Updated

3 years ago
Blocks: 1253062
(Assignee)

Comment 1

3 years ago
Created attachment 8728807 [details] [diff] [review]
patch - Use SurfaceFormat::B8G8R8X8 in BasicCompositor::CreateRenderTarget() if possible
(Assignee)

Updated

3 years ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Updated

3 years ago
Blocks: 1254897
(Assignee)

Comment 3

3 years ago
With talking with jeff, we are going to move CreateRenderTarget() for window to widget.
(Assignee)

Comment 4

3 years ago
(In reply to Sotaro Ikeda [:sotaro] from comment #3)
> With talking with jeff, we are going to move CreateRenderTarget() for window
> to widget.

I changed my mind. BasicCompositor composites not only to widget's screen, but also for making Snapshot. To handle both cases, it seems better to keep the code in BasicCompositor in this bug.
(Assignee)

Comment 5

3 years ago
Created attachment 8730489 [details] [diff] [review]
patch - Use SurfaceFormat::B8G8R8X8 as back buffer in BasicCompositor if possible
Attachment #8728807 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8730489 - Flags: review?(jmuizelaar)
(In reply to Sotaro Ikeda [:sotaro] from comment #4)
> (In reply to Sotaro Ikeda [:sotaro] from comment #3)
> > With talking with jeff, we are going to move CreateRenderTarget() for window
> > to widget.
> 
> I changed my mind. BasicCompositor composites not only to widget's screen,
> but also for making Snapshot. To handle both cases, it seems better to keep
> the code in BasicCompositor in this bug.

What do you still plan to move things into widget? I don't think we want to be doing our weird DIBSection as an image surface business in CreateBackBufferRenderTargetForWindow.
(Assignee)

Comment 8

3 years ago
Okey, I am going to include it in a next patch.
(Assignee)

Updated

3 years ago
Attachment #8730489 - Flags: review?(jmuizelaar)
(Assignee)

Comment 9

3 years ago
(In reply to Jeff Muizelaar [:jrmuizel] from comment #7)
> What do you still plan to move things into widget? I don't think we want to
> be doing our weird DIBSection as an image surface business in
> CreateBackBufferRenderTargetForWindow.

Yes, I am going to plan DIBSection thing in widget. I just put off the thing to another bugs like Bug 1254897 and Bug 1255703.
(Assignee)

Comment 10

3 years ago
Created attachment 8731089 [details] [diff] [review]
patch - Use SurfaceFormat::B8G8R8X8 as back buffer if possible
Attachment #8730489 - Attachment is obsolete: true
(Assignee)

Comment 11

3 years ago
attachment 8731089 [details] [diff] [review] moved a back buffer allocation to widget.
(Assignee)

Updated

3 years ago
Attachment #8731089 - Flags: review?(jmuizelaar)
(Assignee)

Comment 12

3 years ago
Created attachment 8731092 [details] [diff] [review]
patch - Use SurfaceFormat::B8G8R8X8 as back buffer if possible

update nits.
Attachment #8731089 - Attachment is obsolete: true
Attachment #8731089 - Flags: review?(jmuizelaar)
Attachment #8731092 - Flags: review?(jmuizelaar)
Attachment #8731092 - Flags: review?(jmuizelaar) → review+

Comment 14

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d916e4520180
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Depends on: 1258094
(Assignee)

Updated

3 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 15

3 years ago
It causes Bug 1258094.
(Assignee)

Updated

3 years ago
No longer blocks: 1254897
Depends on: 1255703
(Assignee)

Comment 16

3 years ago
Created attachment 8752627 [details] [diff] [review]
patch - Use SurfaceFormat::B8G8R8X8 as back buffer if possible

Rebased.
Attachment #8731092 - Attachment is obsolete: true
Attachment #8752627 - Flags: review+
(Assignee)

Comment 17

3 years ago
Going to re-check in since bug 1255703 is addressed.

Comment 19

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/76361667f62b
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.