Use SurfaceFormat::B8G8R8X8 in BasicCompositor::CreateRenderTarget() if possible

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

(Blocks 1 bug)

unspecified
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

Attachments

(1 attachment, 4 obsolete attachments)

BasicCompositor::CreateRenderTarget() always create draw target as SurfaceFormat::B8G8R8A8.
Assignee: nobody → sotaro.ikeda.g
Blocks: 1254897
With talking with jeff, we are going to move CreateRenderTarget() for window to widget.
(In reply to Sotaro Ikeda [:sotaro] from comment #3)
> With talking with jeff, we are going to move CreateRenderTarget() for window
> to widget.

I changed my mind. BasicCompositor composites not only to widget's screen, but also for making Snapshot. To handle both cases, it seems better to keep the code in BasicCompositor in this bug.
Attachment #8730489 - Flags: review?(jmuizelaar)
(In reply to Sotaro Ikeda [:sotaro] from comment #4)
> (In reply to Sotaro Ikeda [:sotaro] from comment #3)
> > With talking with jeff, we are going to move CreateRenderTarget() for window
> > to widget.
> 
> I changed my mind. BasicCompositor composites not only to widget's screen,
> but also for making Snapshot. To handle both cases, it seems better to keep
> the code in BasicCompositor in this bug.

What do you still plan to move things into widget? I don't think we want to be doing our weird DIBSection as an image surface business in CreateBackBufferRenderTargetForWindow.
Okey, I am going to include it in a next patch.
Attachment #8730489 - Flags: review?(jmuizelaar)
(In reply to Jeff Muizelaar [:jrmuizel] from comment #7)
> What do you still plan to move things into widget? I don't think we want to
> be doing our weird DIBSection as an image surface business in
> CreateBackBufferRenderTargetForWindow.

Yes, I am going to plan DIBSection thing in widget. I just put off the thing to another bugs like Bug 1254897 and Bug 1255703.
Attachment #8730489 - Attachment is obsolete: true
attachment 8731089 [details] [diff] [review] moved a back buffer allocation to widget.
Attachment #8731089 - Flags: review?(jmuizelaar)
update nits.
Attachment #8731089 - Attachment is obsolete: true
Attachment #8731089 - Flags: review?(jmuizelaar)
Attachment #8731092 - Flags: review?(jmuizelaar)
Attachment #8731092 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/d916e4520180
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Depends on: 1258094
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
It causes Bug 1258094.
No longer blocks: 1254897
Depends on: 1255703
Rebased.
Attachment #8731092 - Attachment is obsolete: true
Attachment #8752627 - Flags: review+
Going to re-check in since bug 1255703 is addressed.
https://hg.mozilla.org/mozilla-central/rev/76361667f62b
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.