1255327 - "Canonicalization" is missing from the dictionary

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

https://en.wikipedia.org/wiki/Canonicalization

It's actually a reasonably common term during Firefox dev :-)

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Is this something you'd be interested in taking, Jorg?

Comment 2

[Jorg K (CEST = GMT+2)]

Very geeky, I wouldn't add it but Ehsan can decide. You'd also need the verb "canonicalize" in this case.

Comment 3

[Gian-Carlo Pascutto [:gcp]]

What's the point in leaving the spelling checker dictionary incomplete? Download size?

Comment 4

[Jorg K (CEST = GMT+2)]

That has been discussed far and wide. The Mozilla dictionary uses the "normal" SCOWL size dataset, adds some 37 Mozilla terms (like SpiderMonkey) and thousands of proper names. Since FF 45, it also includes common variants and accented words.

The idea was always to keep the number of uncommon words low, so no uncommon words would be suggested.

There are other approaches to make the dictionary as rich as possible. The en-GB dictionary I'm using for example knows both "Canonicalization" and "canonicalize".

SCOWL have a lookup, http://app.aspell.net/lookup?dict=en_US;words=canonicalize%0D%0ACanonicalization, and those two words are rather rare. So if we followed normal proceedings, we wouldn't add them. Based on this reasoning, Ehsan rejected "inclimate" (bug 1242183). But since it's a computer term, Ehsan might have a different idea here.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

(In reply to Jorg K (GMT+2) from comment #4)
> The idea was always to keep the number of uncommon words low, so no uncommon
> words would be suggested.

I guess that further discussion probably belongs in moz.dev.platform, because we're fixing technical limitations with policy here.

Comment 6

[(no longer active)]

The only downside of adding uncommon words is that they would be suggested as spelling fixes.  I don't think that applies to "canonicalization", so we should add it to our en-US dictionary.  I'd take a patch that does that!

Comment 7

[Jorg K (CEST = GMT+2)]

Would need to add:
canonicalization/MS
and
canonicalize/DGS
for canonicalized, canonicalizing, canonicalizes.

Comment 8

[Ekanan Ketunuti]

Attachment: bug1255327.patch

Comment 9

[(no longer active)]

Comment on attachment 8798306 [details] [diff] [review]
bug1255327.patch

Review of attachment 8798306 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/4fd11f161c9a
Add canonicalization, canonicalizations, canonicalization's, canonicalize, canonicalized, canonicalizing and canonicalizes to the en-US dictionary. r=ehsan

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4fd11f161c9a