Closed Bug 1255375 Opened 4 years ago Closed 4 years ago

MessagePort should not leak if DispatchMessage() fails.

Categories

(Core :: DOM: Core & HTML, defect)

47 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox46 --- fixed
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(2 files)

Attached patch mp1.patchSplinter Review
No description provided.
Attachment #8728943 - Flags: review?(bugs)
Do we need this on branches?
Attachment #8728943 - Flags: review?(bugs) → review+
Comment on attachment 8728943 [details] [diff] [review]
mp1.patch

Approval Request Comment
[Feature/regressing bug #]: MessagePort
[User impact if declined]: a leak if a port dispatches a message and before the runnable is executed the parent window goes away.
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]:  none
[String/UUID change made/needed]: none
Attachment #8728943 - Flags: approval-mozilla-beta?
Attachment #8728943 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/71771eb50228
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment on attachment 8728943 [details] [diff] [review]
mp1.patch

Fixes a mem leak, taking it in Aurora47 and Beta46.
Attachment #8728943 - Flags: approval-mozilla-beta?
Attachment #8728943 - Flags: approval-mozilla-beta+
Attachment #8728943 - Flags: approval-mozilla-aurora?
Attachment #8728943 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/5e9097f4bf87


This doesn't apply cleanly to beta. Can we get a rebased patch?
Flags: needinfo?(amarchesini)
Attached patch beta.patchSplinter Review
Flags: needinfo?(amarchesini)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.