1255404 - handling.properties shouldn't be an override over toolkit's one, and possibly merge

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Axel Hecht [:Pike]]

https://dxr.mozilla.org/mozilla-central/source/mobile/android/locales/jar.mn#82 pretends that chrome://browser/locale/handling.properties would be a substitute for chrome://mozapps/locale/handling/handling.properties.

But they have nothing to do with each other, comparing https://dxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/mozapps/handling/handling.properties and https://dxr.mozilla.org/mozilla-central/source/mobile/android/locales/en-US/chrome/handling.properties.

The only string in the mobile one is used in https://dxr.mozilla.org/mozilla-central/source/mobile/android/components/HelperAppDialog.js#200, and maybe we just merge this into browser.properties?

Also, do we need the toolkit handling.properties? If so, we should use the proper toolkit forwarding for that.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1255404 - detangle handling.properties in android.

Review commit: https://reviewboard.mozilla.org/r/173014/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173014/

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 8901622 [details]
Bug 1255404 - detangle handling.properties in android.

https://reviewboard.mozilla.org/r/173014/#review178514

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 8901622 [details]
Bug 1255404 - detangle handling.properties in android.

Not sure why you turned this from a review to a feedback request. Also, not sure if this needs an explicit review by a peer from the mobile team.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8901622 [details]
Bug 1255404 - detangle handling.properties in android.

Only because I didn't get to finish manual testing before I was going to sleep.

It all looks good now. Asking then for addl. r? from :rnewman's (who added the file I'm removing).

Comment 5

[Richard Newman [:rnewman]]

Looks like most of the handling code, and the other strings in that file, changed in

https://hg.mozilla.org/mozilla-central/rev/9bae6f3fdfb2

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8901622 [details]
Bug 1255404 - detangle handling.properties in android.

Fine by me.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f89f3519cc7e
detangle handling.properties in android. r=Pike

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f89f3519cc7e