use AutoRestore in ObservedDocShell

RESOLVED FIXED in Firefox 48

Status

defect
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: tromey, Assigned: tromey)

Tracking

unspecified
Firefox 48
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
ObservedDocShell.cpp uses MakeScopeExit, but this particular use
would be cleaner with AutoRestore.
Assignee

Comment 1

3 years ago
MozReview-Commit-ID: IbPoXdjfbQu
Assignee

Comment 2

3 years ago
Comment on attachment 8729055 [details] [diff] [review]
use AutoRestore in ObservedDocShell::PopMarkers

As mentioned elsewhere.
Attachment #8729055 - Flags: review?(bugs)
Comment on attachment 8729055 [details] [diff] [review]
use AutoRestore in ObservedDocShell::PopMarkers

thanks
Attachment #8729055 - Flags: review?(bugs) → review+
Assignee

Updated

3 years ago
Keywords: checkin-needed

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/aaa66a4fcd17
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Assignee

Updated

3 years ago
Depends on: 1245743

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.