1255488 - Blank Announcement Banner intermittent on the support forum home and product page home

Status: RESOLVED FIXED

(support.mozilla.org :: Forum, task, P3)

Description

[guigs [:guigs] PST (please needinfo me!)]

Attachment: screenshot of bar.png

Steps to reproduce: 
1. Open firefox after a refresh
2. Log into an admin account
3. Takes you to https://support.mozilla.org/en-US/
4. blank announcement appears breifly, on other pages if not dismissed it will appear at the top of the questions forum. 

Another way to reproduce
1. Make sure you are not signed in, Open a new Private Window in Firefox
2. Navigate to https://support.mozilla.org/en-US/
3. Notice the brief appearance of the announcement bar

Troubleshooting done so far: 
*On the Admin announcement console looked for any blank active entries -> only Korean(may be wrong here on the language) and Italian

Comment 1

[Osmose [:osmose, :mkelly]]

The bar has a class "announce-geoip-suggestion" and I see an error in the JS console that might be related: "Error: Error retrieving geoip data". It's preceded by the following CORS error:

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://location.services.mozilla.com/v1/country?key=fa6d7fc9-e091-4be1-b6c1-5ada5815ae9d. (Reason: missing token 'x-csrftoken' in CORS header 'Access-Control-Allow-Headers' from CORS preflight channel).

In other words, we're asking MLS if we can include an x-csrftoken header and they're denying us. I don't think we actually need a CSRF token for them, though. It's probably some global thing we set in jQuery for all AJAX requests. Or maybe not.

bstoroz: Can you take a look at this when you have a chance?

Comment 3

[Giorgos Logiotatidis [:giorgos]]

Brittany I'll de-assign you from this bug so we can enable others to work on this, due to lack of activity. Thanks for offering to help. Please reach out if you have time to work on this or other bugs.

Comment 6

[Dan]

How much longer until the webmaster will fix this? Been waiting for over 2 months now....

Comment 7

[Giorgos Logiotatidis [:giorgos]]

Hi Daniel,

This is not a priority bug right now, as it's only a annoyance and does not break functionality. We're currently working on redesigning the website.

We always welcome pull requests, so feel free to send us the fix if you have the time.


Thanks

Comment 8

[Emil Ghitta, QA [:emilghitta]]

I am unable to reproduce this issue anymore.

This might have been fixed along the way (also the UI of the SUMO page has changed since this ticket was initially filled). See also https://github.com/mozilla/sumo/issues/4

I'm closing this as Fixed but feel free to re-open this ticket if the issue is still reproducible on your end.