1255491 - Disable pop-out feature in conversation window

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Romain Testard [:RT]]

Given the e10s issue encountered on bug 1250534 we are considering disabling the pop-out feature on the conversation window to prevent the crash scenario from happening.
This bug will only be actioned if we find that bug 1250534 is not fixed on March 14th.

Acceptance criteria:
- Allow disablement of the pop-out button on the conversation through a preference

Comment 1

[Mark Banner (:standard8)]

Bug 1250534 isn't the issue here - that's almost fixed. Its bug 1245813 that's currently the big outstanding one.

Comment 2

[GitHub Autolander Bot]

Attachment: [loop] mancas:bug1255491 > mozilla:master

Comment 3

[Ian Bicking (:ianbicking)]

Note you can pop out the conversation window by dragging the title bar.  I believe this patch only disables the button, do we know if it also disables the drag behavior?

Comment 4

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8730124 [details] [review]
[loop] mancas:bug1255491 > mozilla:master

Hey Dave, as Ian has discovered when dragging the conversation window can be detached, so I've updated the patch to cover that case

Comment 5

[David Critchley (:dcritch)]

Comment on attachment 8730124 [details] [review]
[loop] mancas:bug1255491 > mozilla:master

Works as expected. Tested and wasn't able to drag and button didn't show. Ship it!

Comment 6

[Mark Banner (:standard8)]

Manu: Per discussion in standup today, please ship this with `loop.conversationPopOut.enabled` as `true` - there's other code landing soon that should fix the e10s issues this works around, but we want this just in case we need to turn things off.

Comment 7

[Manuel Casas Barrado [:mancas]]

Landed in master: https://github.com/mozilla/loop/commit/a83ace1bd8a0a17be979b316707b6e88d6d9b265

Comment 8

[Mike de Boer [:mikedeboer]]

Nice! Thanks, Manuel!