Closed Bug 1255499 Opened 4 years ago Closed 4 years ago

Remove SEC_NORMAL from WindowsPreviewPerTab.jsm

Categories

(Core :: DOM: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: ckerschb, Assigned: ckerschb)

References

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file, 1 obsolete file)

No description provided.
Unfortunately we can't remove all of SEC_NORMAL from browser/ right now, e.g. Bug 1232432 is blocked on the docshell changes, but we can't convert all the ones that use the systemPrincipal as the loadingPrincipal.
Assignee: nobody → mozilla
Blocks: 1182535
Status: NEW → ASSIGNED
Depends on: 1206961
Attachment #8729086 - Flags: review?(jonas)
Comment on attachment 8729086 [details] [diff] [review]
bug_1255499_remove_sec_normal_browser.patch

Review of attachment 8729086 [details] [diff] [review]:
-----------------------------------------------------------------

Probably worth splitting this up into two bugs and checking in the MozLoopPushHandler changes right away.

We probably need to audit calls of asyncFetch globally :(

::: browser/modules/WindowsPreviewPerTab.jsm
@@ +83,5 @@
>      channel.setPrivate(privateMode);
>    } catch (e) {
>      // Ignore channels which do not support nsIPrivateBrowsingChannel
>    }
>    NetUtil.asyncFetch(channel, function(inputStream, resultCode) {

Should we add asyncFetch2? Seems like we should do more than just switch the newChannel call here.
Attachment #8729086 - Flags: review?(jonas) → review-
Summary: Remove SEC_NORMAL from browser/ → Remove SEC_NORMAL from WindowsPreviewPerTab.jsm
(In reply to Jonas Sicking (:sicking) from comment #3)
> Should we add asyncFetch2? Seems like we should do more than just switch the
> newChannel call here.

I filed Bug 1257930 to udpate that.
Whiteboard: [domsecurity-active]
Jonas, the MozLoopPushHandler changes already landed within Bug 1257924 and we updated asyncFetch to be able to handle asyncOpen2() within Bug 1257930. This is ready to land but still blocked on the imgLoader changes obviously.
Attachment #8729086 - Attachment is obsolete: true
Attachment #8744882 - Flags: review?(jonas)
Blocks: 1268595
https://hg.mozilla.org/mozilla-central/rev/5b95b76d1b4a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.