[APZ] 10% performance regression on IE mazesolver(40x40)

NEW
Unassigned

Status

()

Core
Layout
2 years ago
a year ago

People

(Reporter: kats, Unassigned)

Tracking

(Depends on: 1 bug, Blocks: 1 bug, {perf, regression})

Trunk
Unspecified
Mac OS X
perf, regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 unaffected, firefox48 fix-optional, firefox49 fix-optional, firefox50 fix-optional)

Details

(URL)

+++ This bug was initially created as a clone of Bug #1220466 +++

See the MazeSolver attachment on bug 1220466 - with APZ enabled vs disabled (e10s enabled in both cases) there is a 10% regression with APZ (on OS X at least).
Depends on: 1256373
I ran the 40x40 maze on OS X March 21 nightly which has the fix from bug 1256373. I ran it 5 times each with APZ on and off (e10s was on in both cases):

Config   e10s+APZ     e10s no-APZ
Samples   24           22
          23           24
          23           23
          24           22
          23           22
--------------------------------------------
Average  23.4s        22.6s
--------------------------------------------

The difference is around 3% here, assuming that this isn't just measurement error/sampling bias. I'll leave this open until bug 1248044 is fixed though, as that might help a bit more.
Depends on: 1248044
Depends on: 1258481
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #1)
> The difference is around 3% here, assuming that this isn't just measurement
> error/sampling bias. I'll leave this open until bug 1248044 is fixed though,
> as that might help a bit more.

Kats: Did that help?
Flags: needinfo?(bugmail.mozilla)
It doesn't appear to have helped. At least, there's still a difference in the latest nightly. Over 5 runs APZ-enabled averaged 23.8s and APZ-disabled averaged 21.8s.
Flags: needinfo?(bugmail.mozilla)

Updated

a year ago
Flags: needinfo?(bugs)
I'm less concerned about MazeSolver per se--more concerned that this is a symptom of something that will show up on real-world sites. How we calculate event-region DisplayItems for APZ could use more optimizing, and that work is tracked in bug 1157834.
status-firefox48: affected → fix-optional
Flags: needinfo?(bugs)
status-firefox47: --- → unaffected
status-firefox49: --- → affected
status-firefox50: --- → affected
Marking this 'fix-optional' and tracking work in bug 1157834 instead.
status-firefox49: affected → fix-optional
status-firefox50: affected → fix-optional
You need to log in before you can comment on or make changes to this bug.