Closed Bug 1255526 Opened 4 years ago Closed 4 years ago

History from I.E. 8 to Firefox is not being imported

Categories

(Firefox :: Migration, defect)

46 Branch
x86
Windows XP
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 48
Tracking Status
firefox45 --- unaffected
firefox46 + verified
firefox47 + verified
firefox48 + verified

People

(Reporter: mfunches, Assigned: Gijs)

References

Details

(Keywords: regression)

Attachments

(1 file)

1) Access IE ver 8 on Windows XP
2) Create: custom homepage, browsing history, saved bookmarks, saved passwords
3) Install Firefox Version 	46.0b1 / Build ID 	20160307215824
4) When available select the option to import from Internet Explorer
Observe: The History is not imported
Also Note:
Selecting the Library "Import and Backup" option, also fails to import the history.
I assume this is a regression. Using the library's import and backup option and mozregression, can you figure out when this regressed?
Flags: needinfo?(mfunches)
Correct: This was regression for E10s  Aurora 46.0a2 & Beta 46.0b1

11:26.49 LOG: MainThread Bisector INFO Last good revision: 30d61283668592adfaec7
a00aeeabc9d32a688c2
11:26.49 LOG: MainThread Bisector INFO First bad revision: 417e00a78107e0e97f35a
3e4df4819cd91f4781d
11:26.49 LOG: MainThread Bisector INFO Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=30d61283668592
adfaec7a00aeeabc9d32a688c2&tochange=417e00a78107e0e97f35a3e4df4819cd91f4781d
Flags: needinfo?(mfunches)
(In reply to Michelle Funches - QA from comment #3)
> Correct: This was regression for E10s  Aurora 46.0a2 & Beta 46.0b1
> 
> 11:26.49 LOG: MainThread Bisector INFO Last good revision:
> 30d61283668592adfaec7
> a00aeeabc9d32a688c2
> 11:26.49 LOG: MainThread Bisector INFO First bad revision:
> 417e00a78107e0e97f35a
> 3e4df4819cd91f4781d
> 11:26.49 LOG: MainThread Bisector INFO Pushlog:
> https://hg.mozilla.org/integration/fx-team/
> pushloghtml?fromchange=30d61283668592
> adfaec7a00aeeabc9d32a688c2&tochange=417e00a78107e0e97f35a3e4df4819cd91f4781d

Any exceptions in the error console when this happens?
Blocks: 1205053
Flags: needinfo?(mfunches)
Keywords: regression
Yes - below are the Browser Console messages

mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create          browser-places.js:640:3
NS_ERROR_ILLEGAL_VALUE: Invalid arguments        nsLivemarkService.js:299:0
typedURLTimeKey is null                          MSMigrationUtils.jsm:714:0
some history did not successfully migrate.
Flags: needinfo?(mfunches)
[Tracking Requested - why for this release]:
This regressed for 46 and dropped off my radar. :-\
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
See Also: → 1261188
Comment on attachment 8737317 [details]
MozReview Request: Bug 1255526 - fix import of typed URLs on versions of windows that do not store timestamps, r?MattN

https://reviewboard.mozilla.org/r/43893/#review40475
Attachment #8737317 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/80bcaeaf9097
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment on attachment 8737317 [details]
MozReview Request: Bug 1255526 - fix import of typed URLs on versions of windows that do not store timestamps, r?MattN

Approval Request Comment
[Feature/regressing bug #]: bug 1205053
[User impact if declined]: can't import history from IE on Windows XP, and maybe other pre-win10 or pre-IE12 (?) versions of Windows / IE
[Describe test coverage new/current, TreeHerder]: no tests because it requires having a browsing history in other browsers
[Risks and why]: very low, just 2 nullchecks.
[String/UUID change made/needed]: nope
Attachment #8737317 - Flags: approval-mozilla-beta?
Attachment #8737317 - Flags: approval-mozilla-aurora?
Verified: History successfully imported.
Version 	48.0a1
Build ID 	20160404030231
User Agent 	Mozilla/5.0 (Windows NT 5.1; rv:48.0) Gecko/20100101 Firefox/48.0
Status: RESOLVED → VERIFIED
Comment on attachment 8737317 [details]
MozReview Request: Bug 1255526 - fix import of typed URLs on versions of windows that do not store timestamps, r?MattN

Verified on nightly, ok to uplift to aurora and beta.
Attachment #8737317 - Flags: approval-mozilla-beta?
Attachment #8737317 - Flags: approval-mozilla-beta+
Attachment #8737317 - Flags: approval-mozilla-aurora?
Attachment #8737317 - Flags: approval-mozilla-aurora+
Tracking, recent regression
Setting the flag for verification on Fx46.
Flags: qe-verify+
Verified this issue as fixed on Windows XP x86 using the following builds:
- Latest 47.0a2 Aurora, build ID: 20160410004056;
- Firefox 46.0b9, build ID: 20160407053945.
[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments:
Test Successful

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Yes,all settings including history has successfully imported.

Actual Results: 
As expected
(In reply to Mayur Patil from comment #19)
> [bugday-20160323]
> 
> Status: RESOLVED,FIXED -> VERIFIED
> 
> Comments:
> Test Successful
> 
> Component: 
> Name			Firefox
> Version			46.0b9
> Build ID		20160322075646
> Update Channel          beta
> User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101
> Firefox/46.0
> OS			Windows 7 SP1 x86_64
> 
> Expected Results: 
> Yes,all settings including history has successfully imported.
> 
> Actual Results: 
> As expected

Mayur Patil, please stop commenting on all the bugs, especially if others have already verified them, or if they are not verifiable by you or on your operating system (version). Please can you talk to folks in #qa on irc.mozilla.org if you want to continue to help with bug verification so they can help you make a positive contribution. As it is, so many of your comments are not useful to the community that it is becoming a problem. Please reply to the needinfo or email me if you have questions.
Flags: needinfo?(ram.nath241089)
OK got it.
Flags: needinfo?(ram.nath241089)
You need to log in before you can comment on or make changes to this bug.