1255526 - History from I.E. 8 to Firefox is not being imported

Status: VERIFIED FIXED

(Firefox :: Migration, defect)

Description

[Michelle Funches - QA]

1) Access IE ver 8 on Windows XP
2) Create: custom homepage, browsing history, saved bookmarks, saved passwords
3) Install Firefox Version 	46.0b1 / Build ID 	20160307215824
4) When available select the option to import from Internet Explorer
Observe: The History is not imported

Comment 1

[Michelle Funches - QA]

Also Note:
Selecting the Library "Import and Backup" option, also fails to import the history.

Comment 2

[:Gijs (he/him)]

I assume this is a regression. Using the library's import and backup option and mozregression, can you figure out when this regressed?

Comment 3

[Michelle Funches - QA]

Correct: This was regression for E10s  Aurora 46.0a2 & Beta 46.0b1

11:26.49 LOG: MainThread Bisector INFO Last good revision: 30d61283668592adfaec7
a00aeeabc9d32a688c2
11:26.49 LOG: MainThread Bisector INFO First bad revision: 417e00a78107e0e97f35a
3e4df4819cd91f4781d
11:26.49 LOG: MainThread Bisector INFO Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=30d61283668592
adfaec7a00aeeabc9d32a688c2&tochange=417e00a78107e0e97f35a3e4df4819cd91f4781d

Comment 4

[:Gijs (he/him)]

(In reply to Michelle Funches - QA from comment #3)
> Correct: This was regression for E10s  Aurora 46.0a2 & Beta 46.0b1
> 
> 11:26.49 LOG: MainThread Bisector INFO Last good revision:
> 30d61283668592adfaec7
> a00aeeabc9d32a688c2
> 11:26.49 LOG: MainThread Bisector INFO First bad revision:
> 417e00a78107e0e97f35a
> 3e4df4819cd91f4781d
> 11:26.49 LOG: MainThread Bisector INFO Pushlog:
> https://hg.mozilla.org/integration/fx-team/
> pushloghtml?fromchange=30d61283668592
> adfaec7a00aeeabc9d32a688c2&tochange=417e00a78107e0e97f35a3e4df4819cd91f4781d

Any exceptions in the error console when this happens?

Comment 5

[Michelle Funches - QA]

Yes - below are the Browser Console messages

mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create          browser-places.js:640:3
NS_ERROR_ILLEGAL_VALUE: Invalid arguments        nsLivemarkService.js:299:0
typedURLTimeKey is null                          MSMigrationUtils.jsm:714:0
some history did not successfully migrate.

Comment 6

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
This regressed for 46 and dropped off my radar. :-\

Comment 7

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1255526 - fix import of typed URLs on versions of windows that do not store timestamps, r?MattN

Review commit: https://reviewboard.mozilla.org/r/43893/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43893/

Comment 8

[Matthew N. [:MattN]]

Comment on attachment 8737317 [details]
MozReview Request: Bug 1255526 - fix import of typed URLs on versions of windows that do not store timestamps, r?MattN

https://reviewboard.mozilla.org/r/43893/#review40475

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/80bcaeaf9097

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/80bcaeaf9097

Comment 11

[:Gijs (he/him)]

Comment on attachment 8737317 [details]
MozReview Request: Bug 1255526 - fix import of typed URLs on versions of windows that do not store timestamps, r?MattN

Approval Request Comment
[Feature/regressing bug #]: bug 1205053
[User impact if declined]: can't import history from IE on Windows XP, and maybe other pre-win10 or pre-IE12 (?) versions of Windows / IE
[Describe test coverage new/current, TreeHerder]: no tests because it requires having a browsing history in other browsers
[Risks and why]: very low, just 2 nullchecks.
[String/UUID change made/needed]: nope

Comment 12

[Michelle Funches - QA]

Verified: History successfully imported.
Version 	48.0a1
Build ID 	20160404030231
User Agent 	Mozilla/5.0 (Windows NT 5.1; rv:48.0) Gecko/20100101 Firefox/48.0

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8737317 [details]
MozReview Request: Bug 1255526 - fix import of typed URLs on versions of windows that do not store timestamps, r?MattN

Verified on nightly, ok to uplift to aurora and beta.

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking, recent regression

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/4cac919cc8d0

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/46a10deb9c42

Comment 17

[Andrei Vaida [:avaida]]

Setting the flag for verification on Fx46.

Comment 18

[Cornel Ionce [:noni]]

Verified this issue as fixed on Windows XP x86 using the following builds:
- Latest 47.0a2 Aurora, build ID: 20160410004056;
- Firefox 46.0b9, build ID: 20160407053945.

Comment 19

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments:
Test Successful

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Yes,all settings including history has successfully imported.

Actual Results: 
As expected

Comment 20

[:Gijs (he/him)]

(In reply to Mayur Patil from comment #19)
> [bugday-20160323]
> 
> Status: RESOLVED,FIXED -> VERIFIED
> 
> Comments:
> Test Successful
> 
> Component: 
> Name			Firefox
> Version			46.0b9
> Build ID		20160322075646
> Update Channel          beta
> User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101
> Firefox/46.0
> OS			Windows 7 SP1 x86_64
> 
> Expected Results: 
> Yes,all settings including history has successfully imported.
> 
> Actual Results: 
> As expected

Mayur Patil, please stop commenting on all the bugs, especially if others have already verified them, or if they are not verifiable by you or on your operating system (version). Please can you talk to folks in #qa on irc.mozilla.org if you want to continue to help with bug verification so they can help you make a positive contribution. As it is, so many of your comments are not useful to the community that it is becoming a problem. Please reply to the needinfo or email me if you have questions.

Comment 21

[Mayur Patil]

OK got it.