remove sutagent/watcher code from source tree

RESOLVED FIXED in Firefox 48

Status

defect
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: jmaher, Assigned: gbrown)

Tracking

unspecified
mozilla48
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

now that android 2.3 is deprecated we do not have android tests running sutagent/watcher code anymore.
fencp, ffxcp, everything under build/mobile/sutagent can go.
Depends on: 1250994
DeviceManagerSUT is still used with Negatus for steeplechase -- DeviceManagerSUT cannot be eliminated.
Assignee: nobody → gbrown
Android 2.3 builds and tests no longer run on trunk trees - bug 1250999.

No harm done by removing sutagent: 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a431c609398
Attachment #8730503 - Flags: review?(jmaher)
Comment on attachment 8730503 [details] [diff] [review]
remove sutagent

Review of attachment 8730503 [details] [diff] [review]:
-----------------------------------------------------------------

we should ensure there is no code in buildbot or autophone that depends on these .apk files existing.  I didn't see any on a simple look.
Attachment #8730503 - Flags: review?(jmaher) → review+
I checked hg.mozilla.org/build and autophone. There are a few references to sutagent in comments and such, and DeviceManagerSUT-like code, but I don't see any evidence of code actually using sutagent, watcher, or fencp.
I still see references to the sut in the dm specification, ...

testing/mochitest/mochitest_options.py:         {"choices": ["adb", "sut"],
testing/mochitest/mochitest_options.py:        elif options.dm_trans == 'sut':

Should we start removing references to it elsewhere?
:ted -- The other day you noted that Steeplechase uses DeviceManagerSUT and Negatus. Do we also need (or want) to continue support for the dm_trans option in test harnesses?
Flags: needinfo?(ted)
https://hg.mozilla.org/mozilla-central/rev/97f8dcf6582c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
(In reply to Geoff Brown [:gbrown] from comment #8)
> :ted -- The other day you noted that Steeplechase uses DeviceManagerSUT and
> Negatus. Do we also need (or want) to continue support for the dm_trans
> option in test harnesses?

Steeplechase does use dmSUT and Negatus, yes, since its whole purpose is to run things on different machines. As to whether you support those in other harnesses I have no opinion.
Flags: needinfo?(ted)
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.