1255527 - remove sutagent/watcher code from source tree

Status: RESOLVED FIXED

(Testing Graveyard :: SUTAgent, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

now that android 2.3 is deprecated we do not have android tests running sutagent/watcher code anymore.

Comment 1

[Geoff Brown [:gbrown] (pto Apr 11-18)]

fencp, ffxcp, everything under build/mobile/sutagent can go.

Comment 2

[Geoff Brown [:gbrown] (pto Apr 11-18)]

DeviceManagerSUT is still used with Negatus for steeplechase -- DeviceManagerSUT cannot be eliminated.

Comment 3

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Attachment: remove sutagent

Android 2.3 builds and tests no longer run on trunk trees - bug 1250999.

No harm done by removing sutagent: 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a431c609398

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8730503 [details] [diff] [review]
remove sutagent

Review of attachment 8730503 [details] [diff] [review]:
-----------------------------------------------------------------

we should ensure there is no code in buildbot or autophone that depends on these .apk files existing.  I didn't see any on a simple look.

Comment 5

[Geoff Brown [:gbrown] (pto Apr 11-18)]

I checked hg.mozilla.org/build and autophone. There are a few references to sutagent in comments and such, and DeviceManagerSUT-like code, but I don't see any evidence of code actually using sutagent, watcher, or fencp.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/97f8dcf6582c

Comment 7

[Bob Clary [:bc] (inactive)]

I still see references to the sut in the dm specification, ...

testing/mochitest/mochitest_options.py:         {"choices": ["adb", "sut"],
testing/mochitest/mochitest_options.py:        elif options.dm_trans == 'sut':

Should we start removing references to it elsewhere?

Comment 8

[Geoff Brown [:gbrown] (pto Apr 11-18)]

:ted -- The other day you noted that Steeplechase uses DeviceManagerSUT and Negatus. Do we also need (or want) to continue support for the dm_trans option in test harnesses?

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/97f8dcf6582c

Comment 10

[(not currently active) Ted Mielczarek]

(In reply to Geoff Brown [:gbrown] from comment #8)
> :ted -- The other day you noted that Steeplechase uses DeviceManagerSUT and
> Negatus. Do we also need (or want) to continue support for the dm_trans
> option in test harnesses?

Steeplechase does use dmSUT and Negatus, yes, since its whole purpose is to run things on different machines. As to whether you support those in other harnesses I have no opinion.