1255563 - Android ./mach xpcshell-test does not set sequential option

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Geoff Brown [:gbrown]]

Running multi-threaded xpcshell tests is arguably too demanding for Android. In automation, Android xpcshell runs with option.sequential = True. I'm sure 'mach xpcshell-test' also set sequential in the past, but it does not currently. Running locally, I see lots of tests timing out.

Comment 1

[Geoff Brown [:gbrown]]

Lost in the option shuffling of http://hg.mozilla.org/mozilla-central/rev/a824847677c5.

Comment 2

[Geoff Brown [:gbrown]]

Attachment: run sequentially in 'mach xpcshell-test'

With this patch I see:

  MainThread INFO Running tests sequentially.

and timeouts and failures are eliminated (tested with 'mach xpcshell-test netwerk/test/unit' against the Android 4.3 emulator).

(I am also sneaking in a string change, trying to make it more clear that the typical cause of a missing APK is that it isn't built / isn't in the objdir.)

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8729183 [details] [diff] [review]
run sequentially in 'mach xpcshell-test'

Review of attachment 8729183 [details] [diff] [review]:
-----------------------------------------------------------------

nice little extra cleanup!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7efd06a8a4ab

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7efd06a8a4ab