1255579 - Failing tests

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

-[TabManagerTests testTabManagerStoresChangesInDB]
-[TestBookmarks testBookmarks]
-[FSUtilsTests testListOpenFileDescriptors]

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I looked at the testTabManagerStoresChangesInDB. This is what happens:

* We create some tabs in that test and then call TabManager.storeChanges()
* storeChanges calls preserveInternal() which tries to create SavedTab instances
* SavedTab.init?() returns nil because those tabs have no history

So no tabs are saved.

Comment 2

[Emily Toop (:fluffyemily)]

Attachment: Pull request

These are not all the tests mentioned in this bug, but a whole bunch more. This just seemed a sensible bug to add them under rather than creating a whole new one.

Comment 3

[Stephan Leroux [:sleroux]]

v4.x 879ace7