-[TabManagerTests testTabManagerStoresChangesInDB] -[TestBookmarks testBookmarks] -[FSUtilsTests testListOpenFileDescriptors]
I looked at the testTabManagerStoresChangesInDB. This is what happens: * We create some tabs in that test and then call TabManager.storeChanges() * storeChanges calls preserveInternal() which tries to create SavedTab instances * SavedTab.init?() returns nil because those tabs have no history So no tabs are saved.
Created attachment 8740958 [details] [review] Pull request These are not all the tests mentioned in this bug, but a whole bunch more. This just seemed a sensible bug to add them under rather than creating a whole new one.
Attachment #8740958 - Flags: review?(bnicholson)
Attachment #8740958 - Flags: review?(bnicholson) → review+
status-fxios-v4.0: --- → fixed
status-fxios-v5.0: --- → fixed
Target Milestone: --- → 4.0
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.