Status

()

RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: st3fan, Assigned: st3fan)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios-v4.0 fixed, fxios-v5.0 fixed, fxios+)

Details

Attachments

(1 attachment)

48 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
-[TabManagerTests testTabManagerStoresChangesInDB]
-[TestBookmarks testBookmarks]
-[FSUtilsTests testListOpenFileDescriptors]
(Assignee)

Comment 1

3 years ago
I looked at the testTabManagerStoresChangesInDB. This is what happens:

* We create some tabs in that test and then call TabManager.storeChanges()
* storeChanges calls preserveInternal() which tries to create SavedTab instances
* SavedTab.init?() returns nil because those tabs have no history

So no tabs are saved.
(Assignee)

Updated

3 years ago
tracking-fxios: --- → ?
Depends on: 1258544
Rank: 1
tracking-fxios: ? → +
Created attachment 8740958 [details] [review]
Pull request

These are not all the tests mentioned in this bug, but a whole bunch more. This just seemed a sensible bug to add them under rather than creating a whole new one.
Attachment #8740958 - Flags: review?(bnicholson)
Attachment #8740958 - Flags: review?(bnicholson) → review+
Whiteboard: [needsuplift]
v4.x 879ace7
status-fxios-v4.0: --- → fixed
status-fxios-v5.0: --- → fixed
Whiteboard: [needsuplift]
Target Milestone: --- → 4.0
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.