Closed
Bug 1255586
Opened 8 years ago
Closed 8 years ago
Expand testInputConnection to include other editor types
Categories
(Firefox for Android Graveyard :: Keyboards and IME, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
Details
Attachments
(1 file)
10.32 KB,
patch
|
esawin
:
review+
|
Details | Diff | Splinter Review |
Currently, testInputConnection only runs tests in a single-line input field. We should expand it to run tests in text areas, content editables, and design mode documents.
Assignee | ||
Comment 1•8 years ago
|
||
Add test cases for text areas, content editables, and design mode editors.
Attachment #8729647 -
Flags: review?(esawin)
Comment 2•8 years ago
|
||
Comment on attachment 8729647 [details] [diff] [review] Add test cases for more input types in testInputConnection (v1) Review of attachment 8729647 [details] [diff] [review]: ----------------------------------------------------------------- r=me with style fixed. ::: mobile/android/tests/browser/robocop/robocop_input.html @@ +13,5 @@ > <p>Hiding input: <input id="hiding-input" type="text"></p> > <script type="application/javascript;version=1.8" src="robocop_head.js"></script> > <script type="application/javascript;version=1.8"> > let input = document.getElementById("input"); > + let text_area = document.getElementById("text-area"); Please use camelCase for variables and functions (more occurrences of it in this patch).
Attachment #8729647 -
Flags: review?(esawin) → review+
Comment 4•8 years ago
|
||
backed out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=9de09b9ee931 since one of this changes caused https://treeherder.mozilla.org/logviewer.html#?job_id=23881111&repo=mozilla-inbound
Flags: needinfo?(nchen)
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ffb463de8bab
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(nchen)
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•