Closed Bug 1255586 Opened 4 years ago Closed 4 years ago

Expand testInputConnection to include other editor types

Categories

(Firefox for Android :: Keyboards and IME, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: jchen, Assigned: jchen)

Details

Attachments

(1 file)

Currently, testInputConnection only runs tests in a single-line input field. We should expand it to run tests in text areas, content editables, and design mode documents.
Add test cases for text areas, content editables, and design mode
editors.
Attachment #8729647 - Flags: review?(esawin)
Comment on attachment 8729647 [details] [diff] [review]
Add test cases for more input types in testInputConnection (v1)

Review of attachment 8729647 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with style fixed.

::: mobile/android/tests/browser/robocop/robocop_input.html
@@ +13,5 @@
>      <p>Hiding input: <input id="hiding-input" type="text"></p>
>      <script type="application/javascript;version=1.8" src="robocop_head.js"></script>
>      <script type="application/javascript;version=1.8">
>        let input = document.getElementById("input");
> +      let text_area = document.getElementById("text-area");

Please use camelCase for variables and functions (more occurrences of it in this patch).
Attachment #8729647 - Flags: review?(esawin) → review+
https://hg.mozilla.org/mozilla-central/rev/ffb463de8bab
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Flags: needinfo?(nchen)
You need to log in before you can comment on or make changes to this bug.