Expand testInputConnection to include other editor types

RESOLVED FIXED in Firefox 48

Status

()

Firefox for Android
Keyboards and IME
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

unspecified
Firefox 48
All
Android
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Currently, testInputConnection only runs tests in a single-line input field. We should expand it to run tests in text areas, content editables, and design mode documents.
(Assignee)

Comment 1

2 years ago
Created attachment 8729647 [details] [diff] [review]
Add test cases for more input types in testInputConnection (v1)

Add test cases for text areas, content editables, and design mode
editors.
Attachment #8729647 - Flags: review?(esawin)
Comment on attachment 8729647 [details] [diff] [review]
Add test cases for more input types in testInputConnection (v1)

Review of attachment 8729647 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with style fixed.

::: mobile/android/tests/browser/robocop/robocop_input.html
@@ +13,5 @@
>      <p>Hiding input: <input id="hiding-input" type="text"></p>
>      <script type="application/javascript;version=1.8" src="robocop_head.js"></script>
>      <script type="application/javascript;version=1.8">
>        let input = document.getElementById("input");
> +      let text_area = document.getElementById("text-area");

Please use camelCase for variables and functions (more occurrences of it in this patch).
Attachment #8729647 - Flags: review?(esawin) → review+

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ffb463de8bab
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
(Assignee)

Updated

2 years ago
Flags: needinfo?(nchen)
You need to log in before you can comment on or make changes to this bug.