1255604 - NS_InputStreamIsBuffered() and NS_OutputStreamIsBuffered() should treat WOULD_BLOCK as buffered

Status: NEW

(Core :: XPCOM, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

As I mentioned in bug 1255070 comment 0, if a stream returns NS_BASE_STREAM_WOULD_BLOCK from ReadSegments() or WriteSegments(), then our IsBuffered() methods treat the stream as unbuffered.  This is wrong.  Just because a stream is async does not mean it is unbuffered.

We should explicitly treat these streams as buffered.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Allow streams that are async and WOULD_BLOCK to be treated as buffered. r=froydnj

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9e87d54c82c