Closed Bug 1255690 Opened 8 years ago Closed 8 years ago

shutdown crash in mozilla::net::`anonymous namespace''::WalkDiskCacheRunnable::Run

Categories

(Core :: Networking: Cache, defect)

Product:
Core
Component:
Networking: Cache
Version:
48 Branch
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox48 --- affected

People

(Reporter: alice0775, Assigned: michal)

References

Details

(Keywords: crash, topcrash, Whiteboard: [necko-active])

Crash Data

This bug was filed from the Socorro interface and is 
report bp-3aa5f34d-8063-4567-9751-bf7682160311.
=============================================================

STR
1. about:preferences#privacy > Enable "Clear history when Firefox closes"
2. Open several web pages
3. Close Browser

Actual Results:
Immediately crash
status-firefox48: --- → affected
Version: 47 Branch → 48 Branch
Component: Untriaged → Networking: Cache
This is the #1 topcrash on nightly, by a lot.  (Hundreds of crashes per day, which is a lot for nightly.)

Regression range is:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=05c087337043&tochange=af7c0cb0798f
Flags: needinfo?(jduell.mcbugs)
Flags: needinfo?(honzab.moz)
1251130?
Assignee: nobody → michal.novotny
Flags: needinfo?(michal.novotny)
Whiteboard: [necko-active]
This is a regression from bug 1251130.  CacheStorageService::IsOnManagementThread() returns false because service->Thread() (forwarding to CacheFileIOManager::IOTarget() static) returns nullptr.  gInstance is null too soon.

We simply must not null out gInstance before the IO thread is completely down.
Blocks: 1251130
Flags: needinfo?(michal.novotny)
Flags: needinfo?(jduell.mcbugs)
Flags: needinfo?(honzab.moz)
Crash Signature: [@ mozilla::net::`anonymous namespace''::WalkDiskCacheRunnable::Run] → [@ mozilla::net::`anonymous namespace''::WalkDiskCacheRunnable::Run] [@ mozilla::net::(anonymous namespace)::WalkDiskCacheRunnable::Run] [@ mozilla::net::::WalkDiskCacheRunnable::Run]
Offending patch has been backed out.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.