1255734 - DevTools: Inspecting a primitive value in console throws a TypeError

Status: RESOLVED FIXED

(DevTools :: Object Inspector, defect, P1)

Description

[Jarda Snajdr [:jsnajdr]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160225030209

Steps to reproduce:

1. Open devtools console.
2. Type 'inspect(1)' - to inspect a primitive value


Actual results:

If you have a browser toolbox console open, you can see a TypeError reported:

TypeError: invalid 'in' operand aGrip

This happens in the VariableViewController._populateFromObject, where there is a statement:

if ("ownPropertyLength" in aGrip)

aGrip is not an object, but it's the primitive number value 1.



Expected results:

No errors.

Comment 1

[Jarda Snajdr [:jsnajdr]]

Attachment: DevTools: Inspecting a primitive value in console throws a TypeError

Adding a patch: 

- in VariablesViewController.setSingleVariable, call this.populate only if the object is not primitive. Otherwise, just return a resolved promise.

- I renamed the parameters of the setSingleVariable method to remove the Hungarian notation and make ESLint happy.

- added a new test case to browser_jsterm_inspect.js. Without the fix, the test times out (the "variablesview-updated" event is never fired).

- slightly refactored the test to use the "variablesview-updated" event instead of "fetched". It works consistently for both primitive and non-primitive values (the "variablesview-fetched" event is fired only when "populate" is called).

Comment 2

[Jarda Snajdr [:jsnajdr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=868482a1c16b

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 8729433 [details] [diff] [review]
DevTools: Inspecting a primitive value in console throws a TypeError

Review of attachment 8729433 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/282de7d09bce

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/282de7d09bce