Closed Bug 1255763 Opened 4 years ago Closed 4 years ago

Misc build system cleanups

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(6 files)

No description provided.
They were behind WANT_MOZILLA_CONFIG_OS_VERSION, which nothing has been
setting ever since the ifdef was changed from
MOZILLA_CONFIG_IGNORE_OS_VERSION... in 2000. Not that anything was
setting MOZILLA_CONFIG_IGNORE_OS_VERSION either... well, at least not in
Gecko.

Review commit: https://reviewboard.mozilla.org/r/39459/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39459/
Attachment #8729475 - Flags: review?(gps)
It has not done anything since gtk+ 1.0 support has been removed in bug 326152.

Review commit: https://reviewboard.mozilla.org/r/39463/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39463/
Attachment #8729477 - Flags: review?(gps)
Comment on attachment 8729478 [details]
MozReview Request: Bug 1255763 - Remove OS_RELEASE and OS_MINOR_RELEASE

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39465/diff/1-2/
Attachment #8729478 - Attachment description: MozReview Request: Bug 1255763 - Remove OS_RELEASE → MozReview Request: Bug 1255763 - Remove OS_RELEASE and OS_MINOR_RELEASE
Comment on attachment 8729473 [details]
MozReview Request: Bug 1255763 - Remove OSTYPE define in intl/locale/unix/moz.build

https://reviewboard.mozilla.org/r/39455/#review36179
Attachment #8729473 - Flags: review?(gps) → review+
Attachment #8729474 - Flags: review?(gps) → review+
Comment on attachment 8729474 [details]
MozReview Request: Bug 1255763 - Remove OS_CONFIG, it is now unused

https://reviewboard.mozilla.org/r/39457/#review36181
Comment on attachment 8729475 [details]
MozReview Request: Bug 1255763 - Remove OS_VERS and OS_VERSION

https://reviewboard.mozilla.org/r/39459/#review36185
Attachment #8729475 - Flags: review?(gps) → review+
Comment on attachment 8729476 [details]
MozReview Request: Bug 1255763 - Remove the MUST_UNDEF_HAVE_BOOLEAN_AFTER_INCLUDES define

https://reviewboard.mozilla.org/r/39461/#review36187
Attachment #8729476 - Flags: review?(gps) → review+
Comment on attachment 8729477 [details]
MozReview Request: Bug 1255763 - Remove the NEED_USLEEP_PROTOTYPE define

https://reviewboard.mozilla.org/r/39463/#review36189
Attachment #8729477 - Flags: review?(gps) → review+
Comment on attachment 8729478 [details]
MozReview Request: Bug 1255763 - Remove OS_RELEASE and OS_MINOR_RELEASE

https://reviewboard.mozilla.org/r/39465/#review36191
Attachment #8729478 - Flags: review?(gps) → review+
pyconfig is sure going to flush out a lot of dead config code like this :)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.