1255767 - Setting a homepage makes Nightly unresponsive

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Attachment: 12674228_10153391977816720_2002759936_n.jpg

Steps to reproduce:
1. Menu -> Settings -> General -> Home-> Set a homepage
2. Choose "Custom" and enter the address or search term:"www.google.com" and tap ok
3. Close Firefox and reopen

Expected results:
- A tab is opened with "www.google.com"

Actual results:
- Nightly crashes, but I cannot see the crash report because after restart a blank page is opened
- Nightly becomes unresponsive and cannot be used anymore
- If I "Force Stop" from Android Settings and tap the Nightly icon it opens for a second and closes.

Regression:
08-03 good build
09-03 affected build

pushlog: 
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=05c087337043dd8e71cc27bdb5b9d55fd00aaa26&tochange=af7c0cb0798f5425d5d344cbaf0ac0ecb1a72a86

Comment 1

[:Margaret Leibovic]

Can you attach a log?

Comment 2

[Teodora Vermesan (:TeoVermesan)]

Attachment: homepagecrash.txt

Here are the attached logs while restarting Nightly and it crashes.

Comment 3

[:Margaret Leibovic]

I see this in the log:

E/GeckoCrashHandler( 4167): java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.indexOf(java.lang.String)' on a null object reference
E/GeckoCrashHandler( 4167): 	at org.mozilla.gecko.toolbar.ToolbarDisplayLayout.updateFromTab(ToolbarDisplayLayout.java:213)
E/GeckoCrashHandler( 4167): 	at org.mozilla.gecko.toolbar.BrowserToolbar.onTabChanged(BrowserToolbar.java:496)
E/GeckoCrashHandler( 4167): 	at org.mozilla.gecko.Tabs$5.run(Tabs.java:674)
E/GeckoCrashHandler( 4167): 	at android.os.Handler.handleCallback(Handler.java:739)
E/GeckoCrashHandler( 4167): 	at android.os.Handler.dispatchMessage(Handler.java:95)
E/GeckoCrashHandler( 4167): 	at android.os.Looper.loop(Looper.java:135)
E/GeckoCrashHandler( 4167): 	at android.app.ActivityThread.main(ActivityThread.java:5254)
E/GeckoCrashHandler( 4167): 	at java.lang.reflect.Method.invoke(Native Method)
E/GeckoCrashHandler( 4167): 	at java.lang.reflect.Method.invoke(Method.java:372)
E/GeckoCrashHandler( 4167): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
E/GeckoCrashHandler( 4167): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)

Mike, Sebastian, I see your names all over this regression window. Any ideas?

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

I touched ToolbarDisplayLayout for the various URL bar updates. I'll have a look.

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1255767 - ToolbarDisplayLayout: Only use baseDomain if it is available. r?margaret.

Review commit: https://reviewboard.mozilla.org/r/39691/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39691/

Comment 7

[:Margaret Leibovic]

Comment on attachment 8730144 [details]
MozReview Request: Bug 1255767 - ToolbarDisplayLayout: Only use baseDomain if it is available. r?margaret.

https://reviewboard.mozilla.org/r/39691/#review36367

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/53961d91a52be96a4f5b2d091206c3bfea3a680b
Bug 1255767 - ToolbarDisplayLayout: Only use baseDomain if it is available. r=margaret.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/53961d91a52b

Comment 10

[Teodora Vermesan (:TeoVermesan)]

Set a homepage, then close Firefox and reopen it. A new tab with that homepage will be displayed:
Verified as fixed using:
Device: One A2001 (Android 5.1.1) 
Build: Firefox for Android 48.0a1 (2016-03-15)

Comment 11

[Kevin Brosnan [:kbrosnan]]

[Tracking Requested - why for this release]: This needs to be uplifted to 47 to match bug 1250671

Comment 12

[Kevin Brosnan [:kbrosnan]]

Uplift to 47 please

Comment 13

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

It'd be great to add a regression test here: I filed bug 1258575.

Comment 14

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8730144 [details]
MozReview Request: Bug 1255767 - ToolbarDisplayLayout: Only use baseDomain if it is available. r?margaret.

Approval Request Comment

[Feature/regressing bug #]: Regression introduced with uplift of bug 1250671.

[User impact if declined]: App crashes if homepage is set and app is started.

[Describe test coverage new/current, TreeHerder]: Local testing and this has been in Nightly for a week.

[Risks and why]: Low - This patch adds an additional null check that got removed with the URL bar behavior changes. It's in Nightly for a week now and there are no known regressions.

[String/UUID change made/needed]: -

Comment 15

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for Fx47, adding crash in keyword tagging.

Comment 16

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8730144 [details]
MozReview Request: Bug 1255767 - ToolbarDisplayLayout: Only use baseDomain if it is available. r?margaret.

Crash fix that was verified and has been in Nightly 48 for a week, taking it in Aurora47.

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/680d97831b62

Comment 19

[Teodora Vermesan (:TeoVermesan)]

Set a homepage, then close Firefox and reopen it. A new tab with that homepage will be displayed:
Verified as fixed using:
Device: One A2001 (Android 5.1.1) 
Build: Firefox for Android 47 Beta 1