Open Bug 1255815 Opened 4 years ago Updated 23 days ago

[mozinfo] Move |update_mozinfo| from mochitest to mozinfo

Categories

(Testing :: Mozbase, defect)

defect
Not set

Tracking

(Not tracked)

People

(Reporter: maja_zf, Unassigned, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(3 obsolete files)

mochitest's runtests.py includes a method that finds mozinfo.json in the directory tree and updates mozinfo.info with it. 

https://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtests.py#553-565

Now in Bug 1253618, Marionette Python runner defines the same method as well, so all the more reason to move this functionality to mozinfo itself.

This might be a good mentored bug.
Code like this is in a few places (~5), and should certainly be consolidated: https://dxr.mozilla.org/mozilla-central/search?q=def+update_mozinfo&redirect=false&case=false
Mentor: james
Keywords: good-first-bug
Summary: Move |update_mozinfo| from mochitest to mozinfo → [mozinfo] Move |update_mozinfo| from mochitest to mozinfo

Hi James,

I would like to work on it. Can I take this up?

Thanks

Flags: needinfo?(james)

Please go ahead.

Assignee: nobody → shivams2799
Flags: needinfo?(james)

Hello James,
I am an Outreachy applicant, and since there is a shortage of good first bugs without assignees, can I still give this one a go ?

Sure, please go ahead.

Attachment #9049940 - Attachment description: {Bug 1255815 - Moved update_mozinfo from mochitest to mozinfo} → Bug 1255815 - Moved update_mozinfo from mochitest to mozinfo
Attachment #9049940 - Attachment description: Bug 1255815 - Moved update_mozinfo from mochitest to mozinfo → {Bug 1255815 - Moved update_mozinfo from mochitest to mozinfo}
Attached file Bug 1255815 - Linting update_mozinfo (obsolete) —

Depends on D22951

Attachment #9049940 - Attachment description: {Bug 1255815 - Moved update_mozinfo from mochitest to mozinfo} → Bug 1255815 - Moved update_mozinfo from mochitest to mozinfo
Attachment #9049943 - Attachment description: Bug 1255815 - Moved update_info from mochitest to mozinfo → Bug 1255815 - Linting update_mozinfo

Hello James,
I created a couple patches because I didn't know if(or how) I could update the same revision when submitting with moz-phab. I'm still learning how to use all these tools and I would appreciate any feedback.

Hi Hafsa are you also working on it? I was already working on it

Thanks

Hello Shivam,
I started working on it since I noticed you haven't submitted a patch for a week, and I couldn't find bugs without assignees.

Attachment #9049940 - Attachment description: Bug 1255815 - Moved update_mozinfo from mochitest to mozinfo → {Bug 1255815 - Moved update_mozinfo from mochitest to mozinfo}
Attachment #9049940 - Attachment description: {Bug 1255815 - Moved update_mozinfo from mochitest to mozinfo} → Bug 1255815 - Moved update_mozinfo from mochitest to mozinfo
Attachment #9049940 - Attachment description: Bug 1255815 - Moved update_mozinfo from mochitest to mozinfo → {Bug 1255815 - Moved update_mozinfo from mochitest to mozinfo} r=jgraham
Attachment #9049940 - Attachment description: {Bug 1255815 - Moved update_mozinfo from mochitest to mozinfo} r=jgraham → Bug 1255815 - Moved update_mozinfo from mochitest to mozinfo r=jgraham
Attachment #9049943 - Attachment is obsolete: true
Attachment #9049949 - Attachment is obsolete: true
Attachment #9049940 - Attachment is obsolete: true
Assignee: shivams2799 → nobody
You need to log in before you can comment on or make changes to this bug.