1255815 - [mozinfo] Move |update_mozinfo| from mochitest to mozinfo

Status: NEW

(Testing :: Mozbase, defect)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

mochitest's runtests.py includes a method that finds mozinfo.json in the directory tree and updates mozinfo.info with it. 

https://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtests.py#553-565

Now in Bug 1253618, Marionette Python runner defines the same method as well, so all the more reason to move this functionality to mozinfo itself.

This might be a good mentored bug.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Code like this is in a few places (~5), and should certainly be consolidated: https://dxr.mozilla.org/mozilla-central/search?q=def+update_mozinfo&redirect=false&case=false

Comment 2

[Shivam Singhal [ :championshuttler ]]

Hi James,

I would like to work on it. Can I take this up?

Thanks

Comment 3

[James Graham [:jgraham]]

Please go ahead.

Comment 4

[hafsa]

Hello James,
I am an Outreachy applicant, and since there is a shortage of good first bugs without assignees, can I still give this one a go ?

Comment 5

[James Graham [:jgraham]]

Sure, please go ahead.

Comment 6

[hafsa]

Attachment: Bug 1255815 - Moved update_mozinfo from mochitest to mozinfo r=jgraham

Comment 7

[hafsa]

Attachment: Bug 1255815 - Linting update_mozinfo

Depends on D22951

Comment 8

[hafsa]

Hello James,
I created a couple patches because I didn't know if(or how) I could update the same revision when submitting with moz-phab. I'm still learning how to use all these tools and I would appreciate any feedback.

Comment 9

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1255815 - Move update_mozinfo from mochitest to mozinfo. r=jgraham

Comment 10

[Shivam Singhal [ :championshuttler ]]

Hi Hafsa are you also working on it? I was already working on it

Thanks

Comment 11

[hafsa]

Hello Shivam,
I started working on it since I noticed you haven't submitted a patch for a week, and I couldn't find bugs without assignees.