1255824 - Pocket-related menu items reappear on restart

Status: VERIFIED FIXED

(Firefox :: Pocket, defect)

Description

[M8R-p7]

When you remove the Pocket toolbar button, some related menu items in the Bookmarks menu and in Reader Mode are also hidden, across all open windows. This hidden state does not persist - they reappear in new windows and on restart.

STR:

0. At each step, check for "View Pocket List" item in the Bookmark Menu(s), and a "Save to Pocket" button in Reader Mode.

1. Create a fresh Firefox profile.
2. Right-click the Pocket button and choose "Remove from Toolbar".
3. Open a new window, or restart Firefox.

Actual Results:
"View Pocket List"/"Save to Pocket" are present in steps 1 and 3.

Expected Results:
"View Pocket List"/"Save to Pocket" are present in step 1 only.

Nightly exhibited this behavior last week, so this might actually be 47 Branch, or that might not make any difference now it's a system add-on (?).

Comment 1

[aleth [:aleth]]

I can confirm this happens on Fx Aurora 47.

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: fix hidden state on startup when pocket button not available

Comment 3

[:Gijs (he/him)]

Comment on attachment 8729706 [details] [diff] [review]
fix hidden state on startup when pocket button not available

Review of attachment 8729706 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/extensions/pocket/bootstrap.js
@@ +439,5 @@
>          "label": gPocketBundle.GetStringFromName("pocketMenuitem.label"),
>          "class": "menuitem-iconic", // OSX only
>          "oncommand": "openUILink(Pocket.listURL, event);"
>        });
> +      menu.hidden = hidden;

I'd just add all of these to the set of attributes you use in createElementWithAttrs, but if there's a reason to prefer this, I don't feel too strongly about it I guess.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: fix hidden state on startup when pocket button not available

comments taken...carry forward r+

Comment 5

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/fx-team/rev/201d6b255e36072ec586e73fe15c084b7b8e7728
Bug 1255824 fix hidden state on startup when pocket button not available, r=gijs

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/201d6b255e36

Comment 7

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8730290 [details] [diff] [review]
fix hidden state on startup when pocket button not available

Approval Request Comment
[Feature/regressing bug #]:pocket bug 1252661
[User impact if declined]:pocket menu items appear even if pocket button is moved into customization palette
[Describe test coverage new/current, TreeHerder]:manual
[Risks and why]: low, simply setting default hidden state on elements
[String/UUID change made/needed]:none

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

M8R-p7tp8h, could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

I want to wait for this fix to stabilize in Nightly for a few days or for the bug opener to verify the fix, before uplifting to Aurora.

Comment 10

[M8R-p7]

Sorry for the delay.
Yes, I can confirm that in Nightly 2016-03-16 I now get the Expected Results when following the STR. Thanks, everyone!

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to M8R-p7tp8h from comment #10)
> Sorry for the delay.
> Yes, I can confirm that in Nightly 2016-03-16 I now get the Expected Results
> when following the STR. Thanks, everyone!

Awesome! Thank you for a prompt verification.

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8730290 [details] [diff] [review]
fix hidden state on startup when pocket button not available

Given that the fix was verified on Nightly, makes sense to uplift to Aurora47.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Recent regression, tracking

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8730290 [details] [diff] [review]
fix hidden state on startup when pocket button not available

Regression in 46, verified on m-c. This should land for the beta 4 build.

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/025c8013b062

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/40f66eb4841f

Comment 17

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments:
Test Successful

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Yes

Actual Results: 
As expected

Comment 18

[Paul Silaghi, QA [:pauly]]

based on comment 10

Comment 19

[Paul Silaghi, QA [:pauly]]

Verified fixed FX 46b10, 47.0a2 (2016-04-13) OS X 10.10.5.