Closed Bug 1255827 Opened 4 years ago Closed 4 years ago

devtools/.eslintrc should list all globals created by Loader.jsm

Categories

(DevTools :: General, defect, P3)

defect

Tracking

(firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 file)

Loader.jsm installs a few globals, like "atob", that are not
in devtools/.eslintrc.  I think they should be.
MozReview-Commit-ID: BkNfuA4Dotj
Attachment #8729607 - Flags: review?(jryans)
Priority: -- → P3
Whiteboard: [btpp-backlog]
Comment on attachment 8729607 [details] [diff] [review]
put loader-defined globals in devtools/.eslintrc

Review of attachment 8729607 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense, thanks!
Attachment #8729607 - Flags: review?(jryans) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/14ab9e505e1f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.