Closed
Bug 1255827
Opened 8 years ago
Closed 8 years ago
devtools/.eslintrc should list all globals created by Loader.jsm
Categories
(DevTools :: General, defect, P3)
DevTools
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
References
Details
(Whiteboard: [btpp-backlog])
Attachments
(1 file)
|
2.72 KB,
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
Loader.jsm installs a few globals, like "atob", that are not in devtools/.eslintrc. I think they should be.
|
Assignee | |
Comment 1•8 years ago
|
||
MozReview-Commit-ID: BkNfuA4Dotj
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8729607 -
Flags: review?(jryans)
|
||
Updated•8 years ago
|
Priority: -- → P3
Whiteboard: [btpp-backlog]
Comment on attachment 8729607 [details] [diff] [review] put loader-defined globals in devtools/.eslintrc Review of attachment 8729607 [details] [diff] [review]: ----------------------------------------------------------------- Makes sense, thanks!
Attachment #8729607 -
Flags: review?(jryans) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa4c69a3c84a
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/14ab9e505e1f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•