Closed Bug 1255836 Opened 10 years ago Closed 10 years ago

MozMMIResult always needs to be rooted

Categories

(Firefox OS Graveyard :: RIL, defect)

Product:
Firefox OS Graveyard
Component:
RIL
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox48 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox48 --- fixed

People

(Reporter: bzbarsky, Assigned: edgar)

Details

Attachments

(1 file)

MozMMIResult always needs to be rooted, v1
2.35 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
There's various stuff in TelephonyDialCallback.cpp that uses MozMMIResult on the stack without rooting it. It needs to be rooted.
Assignee: nobody → echen
Comment on attachment 8731040 [details] [diff] [review] MozMMIResult always needs to be rooted, v1 Review of attachment 8731040 [details] [diff] [review]: ----------------------------------------------------------------- Hi :bz, may I have your review, thank you.
Attachment #8731040 - Flags: review?(bzbarsky)
Comment on attachment 8731040 [details] [diff] [review] MozMMIResult always needs to be rooted, v1 r=me
Attachment #8731040 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/af8f2955805c
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: