bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

MozMMIResult always needs to be rooted

RESOLVED FIXED

Status

Firefox OS
RIL
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bz, Assigned: edgar)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

There's various stuff in TelephonyDialCallback.cpp that uses MozMMIResult on the stack without rooting it.  It needs to be rooted.
(Assignee)

Updated

2 years ago
Assignee: nobody → echen
(Assignee)

Comment 1

2 years ago
Created attachment 8731040 [details] [diff] [review]
MozMMIResult always needs to be rooted, v1
(Assignee)

Comment 2

2 years ago
Comment on attachment 8731040 [details] [diff] [review]
MozMMIResult always needs to be rooted, v1

Review of attachment 8731040 [details] [diff] [review]:
-----------------------------------------------------------------

Hi :bz, may I have your review, thank you.
Attachment #8731040 - Flags: review?(bzbarsky)
Comment on attachment 8731040 [details] [diff] [review]
MozMMIResult always needs to be rooted, v1

r=me
Attachment #8731040 - Flags: review?(bzbarsky) → review+

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/af8f2955805c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.