Closed Bug 1255836 Opened 5 years ago Closed 5 years ago

MozMMIResult always needs to be rooted

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
Tracking Status
firefox48 --- fixed

People

(Reporter: bzbarsky, Assigned: edgar)

Details

Attachments

(1 file)

There's various stuff in TelephonyDialCallback.cpp that uses MozMMIResult on the stack without rooting it.  It needs to be rooted.
Assignee: nobody → echen
Comment on attachment 8731040 [details] [diff] [review]
MozMMIResult always needs to be rooted, v1

Review of attachment 8731040 [details] [diff] [review]:
-----------------------------------------------------------------

Hi :bz, may I have your review, thank you.
Attachment #8731040 - Flags: review?(bzbarsky)
Comment on attachment 8731040 [details] [diff] [review]
MozMMIResult always needs to be rooted, v1

r=me
Attachment #8731040 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/af8f2955805c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.