Closed Bug 1255837 Opened 4 years ago Closed 4 years ago

Expanded text runs to the edge of the window making it hard to read

Categories

(DevTools :: JSON Viewer, defect, P3)

defect

Tracking

(firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox49 --- fixed

People

(Reporter: pascalc, Assigned: davidwalsh)

Details

(Whiteboard: [btpp-backlog])

Attachments

(2 files)

Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0

There is no margin between the window border and the text, making it very hard to read it. See screenshot.
Awesome, thanks for this report!
Priority: -- → P3
Summary: Test sticks to the border of the window making it hard to read the beginning of lines → Expanded text runs to the edge of the window making it hard to read
Whiteboard: [btpp-backlog]
This is partially fixed in the latest release.  Lines no longer wrap to the left, however the padding on the right side is still zero and should probably match the left with 5px to keep it off the edge.
https://reviewboard.mozilla.org/r/47249/#review43939

Should we find a better way to do this?  I can set the 5px myself but should we be storing this in a variable so that spacing stays consistent if someone changes tree-view.css?
Grr, forgot the `r?`
Flags: needinfo?(odvarko)
https://reviewboard.mozilla.org/r/47249/#review44095

::: devtools/client/jsonview/css/main.css:39
(Diff revision 1)
>    padding-right: 17px;
>  }
>  
> +.panelContent .treeTable .treeValueCell {
> +  padding-right: 5px;
> +}

Can you try to add the right padding to the 'panelContent' rule (a few lines above)?

That way we could fix the problem for the Headers tab too.

Honza
Comment on attachment 8742521 [details]
MozReview Request: Bug 1255837 - Add padding to right edge of JSON View JSON Tab. r?Honza

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47249/diff/1-2/
Attachment #8742521 - Attachment description: MozReview Request: Bug 1255837 - Add padding to right edge of JSON View JSON Tab → MozReview Request: Bug 1255837 - Add padding to right edge of JSON View JSON Tab. r?Honza
Attachment #8742521 - Flags: review?(odvarko)
Comment on attachment 8742521 [details]
MozReview Request: Bug 1255837 - Add padding to right edge of JSON View JSON Tab. r?Honza

https://reviewboard.mozilla.org/r/47249/#review44181

Yep, that's what I meant, thanks!

Honza
Attachment #8742521 - Flags: review?(odvarko) → review+
Review done, I am clearing NI flag.

Honza
Flags: needinfo?(odvarko)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/695415714a5d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Assignee: nobody → dwalsh
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.