1255840 - Figure out what IDBFactory is doing with AutoJSAPI

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Boris Zbarsky [:bzbarsky]]

In the mainthread case, we set up an AutoJSAPI using our existing AutoJSContext, but a possibly-different global (esp. in the Xray case).  This _may_ save a frame chain if the global we're using is not same-origin with the default global for that JSContext.

The only thing we seem to use this AutoJSAPI for is the CaptureCaller() bit that uses AutoJSContext and then does nsJSUtils::GetCallingLocation.

For the worker thread, the AutoJSAPI just seems completely unnecessary, since we have a perfectly good JSContext around anyway.

Seems to me like the right thing here is to just nix this AutoJSAPI altogether.  I don't think it's doing anything useful...

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Get rid of the AutoJSAPI usage in IDBFactory

Comment 2

[Boris Zbarsky [:bzbarsky]]

Try run at https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c9449875560 fwiw.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8729619 [details] [diff] [review]
Get rid of the AutoJSAPI usage in IDBFactory

Review of attachment 8729619 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/IDBFactory.cpp
@@ +731,1 @@
>                                        static_cast<nsGlobalWindow*>(reinterpret_cast<nsPIDOMWindow<nsISupports>*>(mWindow.get()))->FastGetGlobalJSObject());

While you're nearby can you just nsGlobalWindow::Cast here?

Comment 4

[Boris Zbarsky [:bzbarsky]]

> While you're nearby can you just nsGlobalWindow::Cast here?

Yep, done.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3149ea08a83f

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3149ea08a83f