1255892 - the link to the japanese build of dev edition is a 404

Status: VERIFIED FIXED

(www.mozilla.org :: Bedrock, defect)

Description

[Josh Mize [:jgmize]]

The bedrock integration tests are failing[0] due to a 404 on a download link[1]. Bouncer is returning a 302 redirect to what appears to be the correct url[2], but that url is a 404.

[0] https://ci.us-west.moz.works/job/bedrock_integration_tests_runner/3212/testReport/tests.functional/test_download_l10n/test_localized_download_links_https___download_mozilla_org__product_firefox_aurora_latest_l10n_os_osx_lang_ja_/
[1] https://download.mozilla.org/?product=firefox-aurora-latest-l10n&os=osx&lang=ja
[2] https://download-installer.cdn.mozilla.net/pub/firefox/nightly/latest-mozilla-aurora-l10n/firefox-47.0a2.ja.mac.dmg

Comment 1

[Rail Aliiev [:rail]]

https://download-installer.cdn.mozilla.net/pub/firefox/nightly/latest-mozilla-aurora-l10n/firefox-47.0a2.ja-JP-mac.mac.dmg is the right one

Comment 2

[Josh Mize [:jgmize]]

(In reply to Rail Aliiev [:rail] from comment #1)
> https://download-installer.cdn.mozilla.net/pub/firefox/nightly/latest-
> mozilla-aurora-l10n/firefox-47.0a2.ja-JP-mac.mac.dmg is the right one

:rail can you fix bouncer so it redirects to the correct URL?

Comment 3

[Rail Aliiev [:rail]]

Oh...

Comment 4

[Josh Mize [:jgmize]]

The 404 is the result of https://bugzilla.mozilla.org/show_bug.cgi?id=1249479 and we need to change product-details in order to use the correct locale for the bouncer link. The download page[0] needs to use the "ja-JP-mac" locale instead of "ja", which is invalid.

[0] https://www.mozilla.org/en-US/firefox/developer/all/?q=Japanese,%20%E6%97%A5%E6%9C%AC%E8%AA%9E
[1] https://download.mozilla.org/?product=firefox-aurora-latest-l10n&os=osx&lang=ja-JP-mac

Comment 5

[Kohei Yoshino [:kohei]]

Yes, we have to use ja-JP-mac instead of ja for osx. Looks like only /firefox/developer/all/ is broken. /firefox/all/, /firefox/beta/all/ and /firefox/organizations/all/ look good. I'll figure out why.

Comment 6

[Paul [:pmac] McLanahan]

I think it's because they only recently stopped building ja and ja-JP-mac for win and linux and that change has only landed in nightly and aurora so far.

Comment 7

[Paul [:pmac] McLanahan]

Do we know what Japanese builds are available for aurora? The only one listed in product-details is "ja". I believe we special-case "ja" in bedrock to insert ja-JP-mac for osx right?

Comment 8

[Paul [:pmac] McLanahan]

Indeed we do:

https://github.com/mozilla/bedrock/blob/1abf290cd44583b7d1f0074dd8e773f2021966d3/bedrock/firefox/firefox_details.py#L204

Comment 9

[Kohei Yoshino [:kohei]]

Attachment: pull request

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/204eeb68095e77181c4c577a49e8a466dabb8e1d
Fix Bug 1255892 - the link to the japanese build of dev edition is a 404

https://github.com/mozilla/bedrock/commit/ef1d1b32707a2cc3ee131119ee2c751ba32731ae
Merge pull request #3970 from kyoshino/bug-1255892-fx-dev-osx-ja

Fix Bug 1255892 - the link to the japanese build of dev edition is a 404

Comment 11

[Josh Mize [:jgmize]]

This fix is now in production and the Japanese OS X download link on https://www.mozilla.org/en-US/firefox/developer/all/ is now working. Thanks Kohei and pmac!